Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemonset CreateAndWaitUntilReady method uses optional conditions field #313

Open
ajaggapa opened this issue Apr 2, 2024 · 0 comments
Open

Comments

@ajaggapa
Copy link
Contributor

ajaggapa commented Apr 2, 2024

CreateAndWaitUntilReady method in daemonset package uses conditions field which is optional.

func (builder *Builder) CreateAndWaitUntilReady(timeout time.Duration) (*Builder, error) {

for _, condition := range builder.Object.Status.Conditions {

Whereas, IsReady method uses desired pod count == ready pod count

func (builder *Builder) IsReady(timeout time.Duration) bool {

if builder.Object.Status.NumberReady == builder.Object.Status.DesiredNumberScheduled {

We are not able utilise CreateAndWaitUntilReady method because conditions field is not getting populated.
https://docs.openshift.com/container-platform/4.15/rest_api/workloads_apis/daemonset-apps-v1.html#status

Wondering if we have any particular reason to use conditions field ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant