Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pod pkg to align with WithVolume pattern #289

Open
trewest opened this issue Mar 25, 2024 · 0 comments
Open

Update pod pkg to align with WithVolume pattern #289

trewest opened this issue Mar 25, 2024 · 0 comments

Comments

@trewest
Copy link
Collaborator

trewest commented Mar 25, 2024

The pod pkg needs to have it's methods aligned with the deployment packages WithVolume method. We should not maintain different WithVolume provider types (like WithLocalVolume) within the pkg. There may be room for enhancement by adding external volume constructor functions within the storage pkg (like NewConfigMapVolumeBuilder(<params>) *corev1.Volume).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant