Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ztp: CNF-14638: Cherry pick CLO6 changes to release-4.16 #2045

Open
wants to merge 5 commits into
base: release-4.16
Choose a base branch
from

Conversation

fontivan
Copy link
Contributor

@fontivan fontivan commented Sep 23, 2024

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 23, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2024
@openshift-ci-robot
Copy link
Collaborator

@fontivan: This pull request references CNF-14458 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target only the "4.16.z" version, but multiple target versions were set.

In response to this:

Includes both PRs that were merged into main

Dropped ztp/kube-compare changes from the originals PRs as kube-compare is not present in release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Sep 23, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@fontivan
Copy link
Contributor Author

/hold do not merge yet

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2024
Copy link
Contributor

openshift-ci bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fontivan
Once this PR has been reviewed and has the lgtm label, please assign imiller0 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fontivan fontivan changed the title ztp: CNF-14458: Cherry pick CLO6 changes to release-4.16 ztp: CNF-14638: Cherry pick CLO6 changes to release-4.16 Sep 24, 2024
@openshift-ci-robot
Copy link
Collaborator

@fontivan: This pull request references CNF-14638 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.z" version, but no target version was set.

In response to this:

Includes both PRs that were merged into main

Dropped ztp/kube-compare changes from the originals PRs as kube-compare is not present in release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-bot bot and others added 4 commits September 24, 2024 08:46
…om fontivan/sskeard/ocpbugs-41368-cluster-logging-6point0'

ztp: CNF-14458: Update source CRs to use Cluster Logging Operator (CLOG) 6.0
…om fontivan/sskeard/cnf-14458-update-channel-name-for-clo'

ztp: CNF-14458: Follow up fixes for channel name & kubecompare-references
…om fontivan/sskeard/cnf-14458-fix-missing-service-account-from-examples'

ztp: CNF-14458: Add cluster log service account CRs to argocd example…
@fontivan fontivan force-pushed the sskeard/cnf-14458-cherry-pick-to-416 branch from bdc4a52 to 5a1cb7a Compare September 24, 2024 12:48
@fontivan
Copy link
Contributor Author

Undrafting PR to allow CI to run though PR still held pending final approvals

@fontivan fontivan marked this pull request as ready for review September 24, 2024 17:17
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 24, 2024
@fontivan
Copy link
Contributor Author

/hold do not merge yet

…rRoleBindings

- ClusterRoleBindings do not have namespaces, and it is currently being ignored when the resources are created
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants