Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically merge community PRs #922

Open
ryanemerson opened this issue Jul 6, 2023 · 3 comments
Open

Automatically merge community PRs #922

ryanemerson opened this issue Jul 6, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@ryanemerson
Copy link
Contributor

Is it possible for community projects to be flagged so that chart PRs are automatically merged?

In the case of the Data Grid product it's possible for a PR to be issued and merged in ~ 4 hours, whereas PRs for the upstream project Infinispan can take over a week. The associated OWNERS of the Infinispan project all work for Red Hat, so from a trust perspective the issuing of Infinispan PRs is the same as the Data Grid product.

@komish
Copy link
Collaborator

komish commented Jul 6, 2023

Red Hat submissions have an automated workflow. I can't see us prioritizing some community submissions over others just because the listed githubUsernames contain Red Hatters at this time. I'll leave this open for now, should we want to revisit.

@ryanemerson
Copy link
Contributor Author

ryanemerson commented Jul 6, 2023

I can't see us prioritizing some community submissions over others just because the listed githubUsernames contain Red Hatters at this time.

I used the fact that Red Hatters contributed to the Infinispan project as an example to show that the basis of trust is effectively the same for that upstream project as downstream. IMO it should be possible for community project PRs to be automatically merged if trusted authors for a given project issue the PR. Is it not possible to enable the automated workflow for community projects? Waiting days/weeks for a release is too long given that we have users waiting on bug fixes/features.

I have updated the issue title to better reflect the request for automatic merging of community projects in general, not necessarily those with Red Hat affiliation.

@ryanemerson ryanemerson changed the title Automatically merge Red Hat affiliated community PRs Automatically merge community PRs Jul 6, 2023
@komish
Copy link
Collaborator

komish commented Jul 6, 2023

It's certainly technically feasible. We mostly need to evaluate the historical reasons for manual approval. At the moment, it's not a priority, but we can consider it in the future.

@komish komish added the enhancement New feature or request label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants