Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error message to be more appropriate when deleting a DA without deleting the SFC #543

Open
3 tasks done
mrajora-1 opened this issue Oct 12, 2017 · 1 comment
Open
3 tasks done

Error message to be more appropriate when deleting a DA without deleting the SFC #543

mrajora-1 opened this issue Oct 12, 2017 · 1 comment
Assignees
@karimull @bmmukund
Labels
improvement/functional priority/3 - medium severity/3 - medium triage/approved/on-hold

Comments

@mrajora-1
Copy link

mrajora-1 commented Oct 12, 2017 •
edited by pravinrajr9
Loading

Description

Error message to be more appropriate when deleting a DA without deleting the SFC

Expected Behavior

Error message should be more suggestive - e.g. DA cannot be deleted unless the SFC is deleted

Actual Behavior

Error message when deleting DA when SFC is not deleted - Distributed Appliance is currently protecting a workload

Steps to Reproduce

  • Create a VC (using SDN - Neutron-sfc), MC, DA, DS, SG.
  • Create SFC.
  • Bind the SG to SFC.
  • Now delete the SG.
  • Delete DA
  • Get an error message - Distributed Appliance is currently protecting a workload
    This suggests that probably there is a SG being protected, whereas, in reality we need to delete the SFC to delete the DA.

Additional Information

WORKAROUND - delete the SFC and then DA delete will be successful

Environment

  • OSC Version/Build: Version: 1.0.0-SNAPSHOT (Build:112-g42e1905, 2017-10-11T18:46:02Z)
  • Cloud Provider Info:
  • Plugin Info:
  • Other:

Status

  • Reproduced
  • In Progress
  • Validated => Verified in Version/Build:

deleting-da-protecting-workload-error

Screenshot taken after solving the issue
deleting da when sfc is binded to sg
@arvindn05 arvindn05 added this to the 0.8.0 milestone Oct 12, 2017
@arvindn05 arvindn05 mentioned this issue Oct 12, 2017
Closed
3 tasks
@arvindn05
Copy link
Member

please Handle #544 as part of this change

@arvindn05 arvindn05 removed this from the 0.8.0 milestone Oct 18, 2017
@bmmukund bmmukund self-assigned this Dec 11, 2017
bmmukund pushed a commit to bmmukund/osc-core that referenced this issue Dec 12, 2017
@balmukundblr
Fixed the issue osc-core issue opensecuritycontroller#543
811aea7
bmmukund pushed a commit to bmmukund/osc-core that referenced this issue Dec 12, 2017
@balmukundblr
Fixed the issue osc-core issue opensecuritycontroller#543
7109846
@bmmukund bmmukund mentioned this issue Dec 12, 2017
Merged
6 tasks
bmmukund pushed a commit to bmmukund/osc-core that referenced this issue Dec 18, 2017
@balmukundblr
Fixed the issue osc-core issue opensecuritycontroller#543
05a5179 
Modified and added test cases.
bmmukund pushed a commit to bmmukund/osc-core that referenced this issue Dec 18, 2017
@balmukundblr
Fixed the issue osc-core issue opensecuritycontroller#543
493c328 
Modified and added test cases.

Added back to original intialization
bmmukund pushed a commit to bmmukund/osc-core that referenced this issue Dec 21, 2017
@balmukundblr
Fixed the issue osc-core issue opensecuritycontroller#543
acccb63 
Modified and added test cases.

Added back to original intialization

Made the changes according to the review comments.
bmmukund pushed a commit to bmmukund/osc-core that referenced this issue Dec 21, 2017
@balmukundblr
Fixed the issue osc-core issue opensecuritycontroller#543
cc54476 
Modified and added test cases.

Added back to original intialization

Made the changes according to the review comments.
bmmukund pushed a commit to bmmukund/osc-core that referenced this issue Dec 27, 2017
@balmukundblr
Fixed the issue osc-core issue opensecuritycontroller#543
239c8b6 
Modified and added test cases.

Added back to original intialization

Made the changes according to the review comments.

Did required changes for unit test case.
bmmukund pushed a commit to bmmukund/osc-core that referenced this issue Dec 28, 2017
@balmukundblr
Fixed the issue osc-core issue opensecuritycontroller#543
2d8bd85 
Modified and added test cases.

Added back to original intialization

Made the changes according to the review comments.

Did required changes for unit test case.

Did the changes as per review comments.
bmmukund pushed a commit to bmmukund/osc-core that referenced this issue Dec 28, 2017
@balmukundblr
Fixed the issue osc-core issue opensecuritycontroller#543
3728d10 
Modified and added test cases.

Added back to original intialization

Made the changes according to the review comments.

Did required changes for unit test case.

Did the changes as per review comments.
bmmukund pushed a commit to bmmukund/osc-core that referenced this issue Dec 28, 2017
@balmukundblr
Fixed the issue osc-core issue opensecuritycontroller#543
0abf5f1 
Modified and added test cases.

Added back to original intialization

Made the changes according to the review comments.

Did required changes for unit test case.

Did the changes as per review comments.
bmmukund pushed a commit to bmmukund/osc-core that referenced this issue Dec 28, 2017
@balmukundblr
Fixed the issue osc-core issue opensecuritycontroller#543
63b7764 
Modified and added test cases.

Added back to original intialization

Made the changes according to the review comments.

Did required changes for unit test case.

Did the changes as per review comments.
bmmukund pushed a commit to bmmukund/osc-core that referenced this issue Dec 29, 2017
@balmukundblr
Fixed the issue osc-core issue opensecuritycontroller#543
06eb96e 
Modified and added test cases.

Added back to original intialization

Made the changes according to the review comments.

Did required changes for unit test case.

Did the changes as per review comments.
sudhirappaji pushed a commit that referenced this issue Jan 15, 2018
@balmukundblr @sudhirappaji
Fixed the issue osc-core issue #543 (#621)
2e8ac34 
* Fixed the issue osc-core issue #543

Modified and added test cases.

Added back to original intialization

Made the changes according to the review comments.

Did required changes for unit test case.

Did the changes as per review comments.

* Changes are incorporated as per the review comments.

* Changes have done as per review comments.

Change1:Reframed the Error Message.
Change2:Renamed the test methods.
Change3:Added the TODO comments for future references.
Change4:Reframed the throw message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karimull karimull

@bmmukund bmmukund

Labels
improvement/functional priority/3 - medium severity/3 - medium triage/approved/on-hold
Milestone
No milestone
Development

No branches or pull requests
4 participants
@arvindn05 @karimull @mrajora-1 @bmmukund