Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 3.0] Planned Breaking Changes for 3.0 in Plugin #3248

Open
7 tasks
peterzhuamazon opened this issue Jan 16, 2025 · 6 comments
Open
7 tasks

[Release 3.0] Planned Breaking Changes for 3.0 in Plugin #3248

peterzhuamazon opened this issue Jan 16, 2025 · 6 comments

Comments

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Jan 16, 2025

[Release 3.0] Planned Breaking Changes for 3.0 in Plugin

As mentioned in this META Issue, we want to track and increase transparency around the breaking changes planned for the 3.0 release across participating plugins.

Please kindly document all planned breaking changes related to your plugin for 3.0 here, by sharing detailed information about the changes, expected impact, and any guidance for users or other teams to adapt to the changes.

If needed, please also prepare PRs on documentation-website changes as part of the 3.0 release process.

Overall, this would help us deliver a smooth and seamless upgrade experience.

Thanks.

Breaking behavior in 3.0+

@penghuo
Copy link
Collaborator

penghuo commented Jan 16, 2025

IMO, OpenSearch DSL format support could be consided deperated in 3.0. The reasons are

  • The response is not structured and does not align with other supported formats, such as JDBC or CSV.
  • Query support is limited; only queries that can be fully translated to OpenSearch DSL are supported.

@dai-chen
Copy link
Collaborator

@penghuo
Copy link
Collaborator

penghuo commented Jan 16, 2025

SQL Plugin Breaking Change Tracker

As part of the OpenSearch 3.0 release plan, we intend to introduce breaking changes. To align with the release timeline, we have defined the following review and decision process:

1. Breaking Change Proposal Collection

We are collecting breaking change proposals. Please add your comments to this thread.
The collection phase will conclude on January 24, 2025.

2. Review and Finalization

A meeting will be scheduled during the last week of January 2025 to review the proposed changes with the maintainers.
The final list of breaking changes will be finalized by January 31, 2025.

Criteria for Breaking Change Candidates

Features that meet any of the following criteria are considered strong candidates for breaking changes:

  • Low Usage or Value: Features that are rarely used or provide minimal benefit to users.
  • Technical Debt: Features that increase system complexity or hinder maintainability.
  • Misalignment with Future Goals: Features that conflict with the product’s long-term vision or updated design principles.

@penghuo penghuo removed the untriaged label Jan 23, 2025
@penghuo
Copy link
Collaborator

penghuo commented Jan 23, 2025

Settings

PPL

  • The AD and KMeans commands could be deprecated. The ML command includes the functionality of both AD and KMeans, making the existing AD and KMeans commands redundant.

Connector

The Prometheus connector and Spark connector are considered experimental features, as they have limited adoption and do not align with our long-term goals. We could consider deprecating them.

@vamsimanohar
Copy link
Member

vamsimanohar commented Jan 27, 2025

In 3.0, we should deprecate the setting to move to PIT from scroll. We can make PIT the default one.
https://github.com/opensearch-project/sql/blob/main/common/src/main/java/org/opensearch/sql/common/setting/Settings.java#L26

@penghuo
Copy link
Collaborator

penghuo commented Jan 28, 2025

Breaking behavior in 3.0+

Reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants