Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Improve error response codes. #2035

Closed
vamsi-amazon opened this issue Aug 29, 2023 · 1 comment
Closed

[BUG] Improve error response codes. #2035

vamsi-amazon opened this issue Aug 29, 2023 · 1 comment
Assignees
Labels
bug Something isn't working Flint v2.12.0 Issues targeting release v2.12.0

Comments

@vamsi-amazon
Copy link
Member

Currently all the internal errors throw Service Unavailable exception which is not apt and should throw internal server failure instead.
Code Pointer: https://github.com/opensearch-project/sql/blob/main/plugin/src/main/java/org/opensearch/sql/plugin/rest/RestPPLQueryAction.java#L148

The ask of this issue is to fix these error response codes in both sql and ppl APIs.

@penghuo
Copy link
Collaborator

penghuo commented Nov 14, 2023

  • Internal Server error should return 500.
  • Customer error should return 4xx.

@penghuo penghuo added the v2.12.0 Issues targeting release v2.12.0 label Nov 14, 2023
@penghuo penghuo added the Flint label Nov 29, 2023
@vamsi-amazon vamsi-amazon self-assigned this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Flint v2.12.0 Issues targeting release v2.12.0
Projects
None yet
Development

No branches or pull requests

3 participants