Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Release workflow is missing 2PR approval process #77

Open
gaiksaya opened this issue May 12, 2023 · 2 comments
Open

[BUG] Release workflow is missing 2PR approval process #77

gaiksaya opened this issue May 12, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@gaiksaya
Copy link
Member

gaiksaya commented May 12, 2023

Describe the bug

Adding this issue as bug because the current 1-click process in this repository lacks this feature. See details here opensearch-project/opensearch-build#3111
Sample PR: opensearch-project/opensearch-java#383

To Reproduce
Push a tag to this repo and release is drafted immediately. It should ask for approval before moving forward

Expected behavior
The release-drafter workflow should be blocked asking for approval from 2 maintainers/codewoners to approve the release.

@joshuali925
Copy link
Member

With 1-click release process any component within opensearch organization is free to release anytime they want. All they need to do is push a tag

Not sure if i understood exactly, is it any component or any client (not a plugin)? Component onboarding mentions instructions for plugins and the 1-click release process, but i thought currently plugins cannot release anytime they want?

@gaiksaya
Copy link
Member Author

We say component because apart from clients we have other components like data-prepper, etc. Plugins are released along with opensearch and dashboards distribution so this process does not apply to them specifically yet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants