Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Search Pipelines in opensearch-js #679

Closed
sejli opened this issue Dec 22, 2023 · 3 comments · Fixed by #716
Closed

[FEATURE] Search Pipelines in opensearch-js #679

sejli opened this issue Dec 22, 2023 · 3 comments · Fixed by #716
Labels
🧗 enhancement New feature or request

Comments

@sejli
Copy link
Member

sejli commented Dec 22, 2023

Is your feature request related to a problem?

The search pipelines feature was released officially in 2.9. Example search with a pipeline:

POST /opensearch_sample_data_flights/_search?search_pipeline=my_pipeline
{
   "query": {
      "match_all:" {}
   }
}

The request in opensearch-js currently does not have a parameter for a search_pipeline.

What solution would you like?

Add a parameter for search_pipeline for search requests.

What alternatives have you considered?

Currently, adding a search_pipeline parameter works, but it is not declared in opensearch-js, and the linter throws errors.

Do you have any additional context?

N/A

@sejli sejli added untriaged 🧗 enhancement New feature or request labels Dec 22, 2023
@sejli sejli changed the title [FEATURE] Search Pipelines [FEATURE] Search Pipelines in opensearch-js Dec 22, 2023
@nhtruong
Copy link
Collaborator

Thanks @sejli
I've raised an issue in the API Spec repo as eventually this will be handled by a client generator that will read the spec and generate the API code. We're currently working on the generator ourselves.

In the meantime, feel free to raise a PR to update the input type for the search operation if no one has gotten to it. If you have any questions, don't hesitate to ask :)

@sumukhswamy
Copy link

@nhtruong any update on this? The PR was closed recently.

@nhtruong
Copy link
Collaborator

nhtruong commented Apr 4, 2024

It was probably closed by mistake. Just restored it. Lemme rebase it and get it merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧗 enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants