Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [CCI] BaseConnectionPool empty methods #429

Open
timursaurus opened this issue Mar 12, 2023 · 0 comments
Open

[BUG] [CCI] BaseConnectionPool empty methods #429

timursaurus opened this issue Mar 12, 2023 · 0 comments
Labels
🐛 bug Something isn't working CCI College Contributor Initiative

Comments

@timursaurus
Copy link
Collaborator

timursaurus commented Mar 12, 2023

What is the bug?

BaseConnectionPool methods markAlive and markDead are not implemented, but are called and passed connection argument, example:

// BaseConnectionPool.js
if (connectionById) {
  ...
  this.markAlive(connectionById);
  ...

They just return instance of the class. See:

// BaseConnectionPool.js
markAlive() { // <-- takes no arguments
  return this;
}
markDead() {
  return this;
}

Should be

markAlive(connection) {
  connection.status = Connection.statuses.ALIVE;
  return this;
 }

Two classes, ConnectionPool and CloudConnectionPool, are extensions of the BaseConnectionPool class. While ConnectionPool implements the markDead and markAlive methods within the class, but CloudConnectionPool does not. This means that when using CloudConnectionPool, calling these methods has no effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working CCI College Contributor Initiative
Projects
None yet
3 participants