You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #279 we have added a vendor-specific, aws4 library as a dependency. By design we avoid vendor-specific code to not advantage any one vendor one way or another.
What solution would you like?
A way to make that dependency optional or potentially splitting opensearch-js into opensearch-js and an addon called opensearch-aws-js.
The text was updated successfully, but these errors were encountered:
From my understanding, optionalDependencies exist in npm but don't work in this use case because we would need to somehow pull in the dependency if a user requests to use the signer. It merely allows us to check if the dependency is installed and proceed without if not.
We would just need to create a separate package that we can import if needed.
Also, I see from other client implementations that we have vendor specific code in every client with sigv4. Do we open a meta issue in OpenSearch Clients to fix all of them?
Is your feature request related to a problem?
In #279 we have added a vendor-specific,
aws4
library as a dependency. By design we avoid vendor-specific code to not advantage any one vendor one way or another.What solution would you like?
A way to make that dependency optional or potentially splitting
opensearch-js
intoopensearch-js
and an addon calledopensearch-aws-js
.The text was updated successfully, but these errors were encountered: