Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add positive output to the generator #285

Closed
dblock opened this issue May 7, 2024 · 0 comments · Fixed by #322
Closed

[FEATURE] Add positive output to the generator #285

dblock opened this issue May 7, 2024 · 0 comments · Fixed by #322
Assignees
Labels
enhancement New feature or request

Comments

@dblock
Copy link
Member

dblock commented May 7, 2024

Is your feature request related to a problem?

It's unclear whether the generator worked.

$ npm run merge -- $ROOT_PATH $OUTPUT_PATH

> [email protected] merge
> ts-node merger/merge.ts ../spec ../build/opensearch-openapi.yaml

Path not found: /_plugins/_alerting/destinations
Path not found: /_plugins/_alerting/destinations/email_accounts/_search
Path not found: /_plugins/_alerting/destinations/email_accounts/{emailAccountID}
Path not found: /_plugins/_alerting/destinations/email_groups/_search
Path not found: /_plugins/_alerting/destinations/email_groups/{emailGroupID}
Path not found: /_plugins/_alerting/destinations/{destinationID}
Path not found: /_plugins/_alerting/monitors
Path not found: /_plugins/_alerting/monitors/_execute

What solution would you like?

  1. The generator should output some messages such as "Wrote build/opensearch-openapi.yaml successfully."
  2. The generator should not output errors as warnings.

Some other ideas:

  1. Add --verbose for detailed output.
  2. The generator parameters should be named, e.g. npm run merge -- src/... -o output/file.yml --verbose

What alternatives have you considered?

N/A

Do you have any additional context?

I was trying to run the generator and got confused by the output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant