Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Ml-commons plugin introducing a new optional field "config" in MLTooSpec #878

Open
jngz-es opened this issue Sep 23, 2024 · 1 comment · May be fixed by #899
Open

[FEATURE] Ml-commons plugin introducing a new optional field "config" in MLTooSpec #878

jngz-es opened this issue Sep 23, 2024 · 1 comment · May be fixed by #899
Assignees
@dbwiddis
Labels
enhancement New feature or request v2.18.0 Issues targeting release v2.18.0

Comments

@jngz-es
Copy link

jngz-es commented Sep 23, 2024

Is your feature request related to a problem?

Ml-commons is introducing a new field config in MLToolSpec as showed in the pr opensearch-project/ml-commons#2977. With the change, we allow cx to configure some static parameters for tools that stay unchanged/persist during the tool execution. It will fix a couple of bugs mentioned in the pr.

What solution would you like?

The pr opensearch-project/ml-commons#2977.

What alternatives have you considered?

N/A.

Do you have any additional context?

It's an optional field.
@jngz-es jngz-es added enhancement New feature or request untriaged labels Sep 23, 2024
@jngz-es jngz-es mentioned this issue Sep 23, 2024
Open
5 tasks
@dbwiddis dbwiddis added good first issue Good for newcomers v2.18.0 Issues targeting release v2.18.0 and removed untriaged labels Sep 23, 2024
@dbwiddis
Copy link
Member

This should be a simple change to the ToolStep class adding the new optional parameter.

@dbwiddis dbwiddis self-assigned this Oct 3, 2024
@dbwiddis dbwiddis removed the good first issue Good for newcomers label Oct 3, 2024
@dbwiddis dbwiddis linked a pull request Oct 3, 2024 that will close this issue
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbwiddis dbwiddis

Labels
enhancement New feature or request v2.18.0 Issues targeting release v2.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add optional config field to tool step dbwiddis/flow-framework
2 participants
@dbwiddis @jngz-es