Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] Improve Workflow State Resource updates #779

Closed
dbwiddis opened this issue Jul 12, 2024 · 1 comment · Fixed by #894
Closed

[REFACTOR] Improve Workflow State Resource updates #779

dbwiddis opened this issue Jul 12, 2024 · 1 comment · Fixed by #894
Assignees
Labels
enhancement New feature or request v2.18.0 Issues targeting release v2.18.0

Comments

@dbwiddis
Copy link
Member

dbwiddis commented Jul 12, 2024

Is your feature request related to a problem?

Currently the Workflow State resource document is only additive, using a Painless script during provisioning to append to a list. This prevented iteratively updating it during deprovisioning, leading to open questions like #691.

Following #778 we will have the ability to update any individual element of the Workflow State which will bring these benefits:

  • Allow for incremental addition to the resources created without using Painless, improving portability
  • Allow for incremental removal from the resources created during deprovisioning, allowing the full deprovisioning to depend on this update. (See [FEATURE] Update WorkflowState resources during deprovisioning #780)
  • Allow for the easy removal of the "error" field on subsequent successful provisioning

What solution would you like?

Replace the painless script with appropriate code from #778. Use ifSeqNo() and ifPrimaryTerm() on the update requests to enforce concurrency, and retry if it fails.

@dbwiddis dbwiddis added enhancement New feature or request untriaged labels Jul 12, 2024
@dbwiddis dbwiddis added backlog Good to have functionality not critical for next release and removed untriaged labels Jul 12, 2024
@dbwiddis
Copy link
Member Author

Coming from #763 (comment), there's a lot of repetitive boilerplate used in Workflow Steps for exception handling during resource updates. As part of this refactoring, the "failed" update code should be de-duplicated.

@dbwiddis dbwiddis self-assigned this Jul 18, 2024
@dbwiddis dbwiddis added v2.18.0 Issues targeting release v2.18.0 and removed backlog Good to have functionality not critical for next release labels Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.18.0 Issues targeting release v2.18.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant