Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] Refactor Builders to avoid need for instantiation #776

Closed
dbwiddis opened this issue Jul 10, 2024 · 0 comments · Fixed by #778
Closed

[REFACTOR] Refactor Builders to avoid need for instantiation #776

dbwiddis opened this issue Jul 10, 2024 · 0 comments · Fixed by #778
Assignees
Labels
enhancement New feature or request

Comments

@dbwiddis
Copy link
Member

Is your feature request related to a problem?

Instantiating a builder shouldn't require so much new in the code.

What solution would you like?

Change builder instantiation from the current new Template.Builder() to static method Template.builder(). (Use multiple methods for the ones with arguments.)

These can be easily replaced in code via regex search/replace.

Can do similar for the Workflow State builder, probably at the same time as #713

Do you have any additional context?

Sample PR for what I want to do:

@dbwiddis dbwiddis added enhancement New feature or request good first issue Good for newcomers untriaged labels Jul 10, 2024
@dbwiddis dbwiddis self-assigned this Jul 12, 2024
@dbwiddis dbwiddis removed good first issue Good for newcomers untriaged labels Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant