Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check internal consistency #39

Open
lewisjared opened this issue Apr 16, 2020 · 0 comments
Open

Check internal consistency #39

lewisjared opened this issue Apr 16, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@lewisjared
Copy link
Collaborator

Describe the solution you'd like
From comment in #22

It would be great to add some way of easily telling if the data is internally consistent or not (e.g. does the same of Emissions|CO2|X add up to Emissions|CO2 and are the regional sums equal to world). I don't know what the best approach is, whether it's a new class (in which case you'd check data was internally consistent before adding it) or adding an attribute e.g. internally_consistent to ScmRun (in which case you could have a method which could check for the internal consistency). I think I'd go for the first because more often than not you know whether you want the data to be internally consistent or not before you start and with the second you run the risk that you start with consistent data, then add new data, then forget to check the internal consistency again and things blow up.

@lewisjared lewisjared added the enhancement New feature or request label Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant