Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce reviewer comments for file groups containing files with changes requested #726

Open
LFISHER7 opened this issue Dec 19, 2024 · 2 comments

Comments

@LFISHER7
Copy link

You don't currently have to write a reviewer comment for a file group that contains a file you have requested changes for. This means a request can be returned with changes required, but no detail on what changes.

Reviewers should each have to write a comment before they submit their request in these cases. There should also be a public comment before the request is returned.

See this Slack thread for more detail.

@LFISHER7
Copy link
Author

Similarly, it looks like the requester is not required to add a new comment describing changes they make following a file being marked as requiring changes. The requester should have to write a comment before they can resubmit a file group containing such a file

@LFISHER7
Copy link
Author

I think they can however, update the context and controls. When they do this, it's not obvious that's what they've done and what the changes are. I think the context/controls should remain fixed across review rounds, and ask for any changes to context/controls to be indicated as comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant