Skip to content

Commit 61380e0

Browse files
committed
Only bump Maven plugin version property when needed
1 parent 4881ffd commit 61380e0

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

rewrite-maven/src/main/java/org/openrewrite/maven/UpgradePluginVersion.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,8 +182,10 @@ public Xml visitTag(Xml.Tag tag, ExecutionContext ctx) {
182182
if (versionTag.isPresent()) {
183183
String version = versionTag.get().getValue().orElse(null);
184184
if (version != null) {
185-
if (version.trim().startsWith("${") && !newVersion.equals(getResolutionResult().getPom().getValue(version.trim()))) {
186-
doAfterVisit(new ChangePropertyValue(version, newVersion, false, false).getVisitor());
185+
if (version.trim().startsWith("${")) {
186+
if (!newVersion.equals(getResolutionResult().getPom().getValue(version.trim()))) {
187+
doAfterVisit(new ChangePropertyValue(version, newVersion, false, false).getVisitor());
188+
}
187189
} else if (!newVersion.equals(version)) {
188190
doAfterVisit(new ChangeTagValueVisitor<>(versionTag.get(), newVersion));
189191
}

0 commit comments

Comments
 (0)