Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECAT] [BUG] FBP Scaling Negative Values Error #272

Closed
bendhouseart opened this issue Feb 20, 2024 · 6 comments · Fixed by #278
Closed

[ECAT] [BUG] FBP Scaling Negative Values Error #272

bendhouseart opened this issue Feb 20, 2024 · 6 comments · Fixed by #278
Assignees

Comments

@bendhouseart
Copy link
Contributor

bendhouseart commented Feb 20, 2024

I've had the chance to do some testing. It seems to work fine on OSEM images, and values within the brain for FBP look fine but values outside the brain in FBP still seem off. These seem to match up with the negative valued voxels in the original FBP ECAT image. As far as I know, negative values are valid in FBP reconstructions, however this version of ecat2nii takes the negative values in the FBP image and scales them to brighter than the brain values, which will cause issues during processing.

Can the PET2BIDS team confirm whether this issue occurs when converting the supplied FBP ECAT file under the current version of ecatpet2bids?

Originally posted by @noahg-neuroimage in #268 (comment)

@noahg-neuroimage
Copy link
Contributor

@bendhouseart Thanks for moving the discussion here. To be clear, the issue here is more apparent in the last frames of the image, where you'll notice the image center after conversion to Nifti/Bids is much darker than the surrounding noise. However, I'd still like to verify whether this issue occurs just for me, or if it is apparent for the developers at PET2BIDS as well.

@CPernet
Copy link
Contributor

CPernet commented Feb 26, 2024

@mnoergaard checked some of this - one issue seems to be ecat 6x but our doc says we support ecat 7+ - so I'm going to recheck some aspect, but do not intend to support older ecat

@bendhouseart
Copy link
Contributor Author

Matlab fix applied here -> 9beee53

@CPernet
Copy link
Contributor

CPernet commented Mar 7, 2024

@bendhouseart silly me, the matlab code does something much simpler ... read data as int16 and output as int16 ; what the out from your python, float?

@CPernet
Copy link
Contributor

CPernet commented May 13, 2024

great ! fixed :-) I also found someone who is giving us a phantom with such 'fun' data

@noahg-neuroimage
Copy link
Contributor

By the way, I've had a chance to use this and it seems to be working great! Thanks for all the hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants