-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Att/Detach volume request syntax discrepancy #573
Comments
I guess the doc is not up to date yet, maybe we will update the doc when we have time soon .. thanks for report that @dongyanyang FYI |
@johnarwe Hi john, thanks, the documents is outdated and I forget to maintain it.
I commit a pull request here: #585 to update the docs, please help review, thanks. |
Related but different question: once the PR merges, is the documentation site automatically updated (perhaps with a minor delay for rebuilding from the source), or is the site updated less frequently and/or by hand? The presence of release numbers might be read to imply that merges are batched and the site regenerated (with a new minor version bump) less often than "with every merge". I don't care which it is, I'm just trying to set my own expectations accurately. |
there is no Jenkins job assigned which means not able to update every time so we manually trigger this time to time to build and online latest doc |
Attach volume says in the parameter table that
assigner_id
is specified in (presumably, the request URI)path
, but the example shows it within theconnection
dictionary.Detach volume has the same discrepancy. Detach's parameters and example look like an exact copy of Attach's, which seems suspicious. I'm not sure how specifying
is_root_volume
on a Detach Volume request helps, or would be used. It might be that detach should say that extra/unknown parameters are ignored (that seems like it would be a useful statement at a higher level "all Feilong APIs...", if it's true, since unknown parameters could just as likely result in a request being rejected).The text was updated successfully, but these errors were encountered: