You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would like to raise discussion of completely changing the interface to \editionMod, as I find it confusing to have functions with so many unnamed parameters.
I would suggest an approach with named parameters, either optional Scheme parameters or a \with construct (ly:context-mod?). This would make the input more explicit, and it would make it easier to add more options and/or add flexibility. As an example that way one could integrate the addressing by rehearsal mark offsets.
Such an approach would imply more markup overhead, I know. But that could be alleviated by having many parameters default to a value, which could make the code more readable as well.
Something like
\setOption edition-engraver.target-edition test
\setOption edition-engraver.target sing.with.bach.along
\editionMod\with {
moment =#'(20/4)
mod = { \once\overrideNoteHead.color =#red }
}
\editionMod\with {
hook = Blupp
moment =#6/4
mod = ...
}
This is not thought through at all yet, just meant as a start for discussion. This approach will generally produce more code but I think that code will be more readable, and it will be more natural to write.
The text was updated successfully, but these errors were encountered:
If we agree on something I could give it a try (although I don't know if I manage to do so. Maybe I could be challenged to do so before having my presentation at the MEC)
I understand your concerns about the unnamed parameters. But I would only add this named one-parameter-blob as another option. For now I think, we need another function, because I doubt that the optional parameters can't deal with one blob or several parms.
But perhaps we find another solution.
I would in any case develop it as another function. And if it should turn out to be useful or even superior I would then first "deprecate" the old function.
I would like to raise discussion of completely changing the interface to
\editionMod
, as I find it confusing to have functions with so many unnamed parameters.I would suggest an approach with named parameters, either optional Scheme parameters or a
\with
construct (ly:context-mod?
). This would make the input more explicit, and it would make it easier to add more options and/or add flexibility. As an example that way one could integrate the addressing by rehearsal mark offsets.Such an approach would imply more markup overhead, I know. But that could be alleviated by having many parameters default to a value, which could make the code more readable as well.
Something like
This is not thought through at all yet, just meant as a start for discussion. This approach will generally produce more code but I think that code will be more readable, and it will be more natural to write.
The text was updated successfully, but these errors were encountered: