Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable page title #38

Closed
jbelien opened this issue Dec 12, 2020 · 3 comments · Fixed by #77
Closed

Configurable page title #38

jbelien opened this issue Dec 12, 2020 · 3 comments · Fixed by #77
Assignees

Comments

@jbelien
Copy link
Member

jbelien commented Dec 12, 2020

The about page uses the title defined in the CMS.

<Header>
  <Title as="h1">{data.seo?.title}</Title>
</Header>

https://github.com/openknowledgebe/website/blob/main/src/pages/about.js#L31

It should be the same for ALL the pages (team, activities, stories) ; currently the page title is hardcoded and not using the title defined in the CMS.

<Title as="h1" css="margin-bottom: 3rem;">
  Our <br />
  activities
</Title>

https://github.com/openknowledgebe/website/blob/main/src/pages/activities.js#L42-L45

<Title as="h1">
  Our <br />
  stories
</Title>

https://github.com/openknowledgebe/website/blob/main/src/pages/stories.js#L28-L31

<Title as="h1">
  Our <br />
  Team
</Title>

https://github.com/openknowledgebe/website/blob/main/src/pages/team.js#L138-L141

Styling should also be the same (see css="margin-bottom: 3rem;" for activities page) !

@auloin
Copy link
Contributor

auloin commented Dec 12, 2020

The issue here is that some of the titles are on 2 lines (<br />).

  • We may assume that every title will break into (max) 2 lines and use JS to make it happen
  • or that the width is so small that every word will create a newline
  • or that users will take care of breaking titles and provide them with a minimal markdown widget
  • or ...

The current assumption is that these titles won't change too often.

@jbelien
Copy link
Member Author

jbelien commented Dec 12, 2020

To be honest, I don't see the reason behind the <br /> between the 2 words ...

Couldn't we just display the title (they are rather small anyway) without any formatting ?

@jbelien
Copy link
Member Author

jbelien commented Dec 18, 2020

The "issue" with the <br /> is not existent anymore since all titles have been updated (see #61 (comment)).

You can move forward with this request and make all titles configurable. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants