-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: ngsPETSc: A coupling between NETGEN/NGSolve 2 and PETSc #7359
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Software report:
Commit count by author:
|
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
Review checklist for @knepleyConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@thelfer & @knepley - Thanks for agreeing to review this submission. As you can see above, you each should use the command As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention We aim for reviews to be completed within about 2-4 weeks. Please let me know if either of you require some more time. We can also use editorialbot (our bot) to set automatic reminders if you know you'll be away for a known period of time. Please feel free to ping me (@danielskatz) if you have any questions/concerns. |
Review checklist for @thelferConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@danielskatz Looking at the repo, based on the number of commits, number of lines, and recently opened MRs, the authors should probably also include JDBetteridge in the author list. How do you normally approach this at JOSS? |
@knepley - This is really a question for the author, rather than for JOSS. 👋 @UZerbinati - can you say something about this? |
@danielskatz Oh, I meant "I am allowed to talk directly to the author", so I guess the answer is yes :) |
Yes! JOSS reviewers are meant to be interactive between the author(s) and reviewers, with my role being to keep things on track and progressing. Think of this like any other open source software discussion. |
@UZerbinati There is not really a State of the Field in the paper, which would be a brief list of packages with similar capabilities, maybe DUNE or FreeFEM? |
@UZerbinati I don't see guidelines for contributing. Perhaps it would be enough to point to the Firedrake guidelines in the documentation? |
Dear @danielskatz and @knepley, the reason why Jack is not among the authors is the fact that most of his contributions were made after the submission of this manuscript. After talking with the other authors and Jack, we decided to add Jack among the paper's authors. |
As suggested by @knepley in openjournals/joss-reviews#7359 we added contribution guidelines.
As suggested by @knepley in openjournals/joss-reviews#7359 we added contribution guidelines.
👋 @thelfer - Will you be able to start on your review soon? |
I'll start my review next week after my vacations :) |
👋 @thelfer - How are things going now? |
@editorialbot check references |
|
@UZerbinati - I have suggested some small changes in NGSolve/ngsPETSc#67 - please merge this. Also, I note there is no Acknowledgements section in your paper. Should there be, mentioning any funding or anything else? |
@editorialbot generate pdf |
👋 @UZerbinati - thanks for merging the PR. Once you've decided on the Ack section and perhaps made a change to add it, please
I can then move forward with accepting the submission. |
Dear @danielskatz, |
@editorialbot generate pdf |
@editorialbot set 10.5281/zenodo.14295034 as archive |
Done! archive is now 10.5281/zenodo.14295034 |
@editorialbot set 0.0.8 as version |
Done! version is now 0.0.8 |
@editorialbot recommend-accept |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#6237, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🦋🦋🦋 👉 Bluesky post for this paper 👈 🦋🦋🦋 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations to @UZerbinati (Umberto Zerbinati) and co-authors on your publication!! And thanks to @thelfer and @knepley for reviewing! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @UZerbinati (Umberto Zerbinati)
Repository: https://github.com/NGSolve/ngsPETSc
Branch with paper.md (empty if default branch):
Version: 0.0.8
Editor: @danielskatz
Reviewers: @thelfer, @knepley
Archive: 10.5281/zenodo.14295034
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@thelfer & @knepley, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @danielskatz know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @knepley
📝 Checklist for @thelfer
The text was updated successfully, but these errors were encountered: