Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: PyroRL: A Reinforcement Learning Environment for Wildfire Evacuation #6639

Closed
editorialbot opened this issue Apr 17, 2024 · 44 comments
Assignees
Labels
pre-review Python TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Apr 17, 2024

Submitting author: @cpondoc (Christopher Pondoc)
Repository: https://github.com/sisl/PyroRL
Branch with paper.md (empty if default branch): master
Version: v1.0.1
Editor: @mikemahoney218
Reviewers: @SamTov, @shahchiragh
Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/b9f135b1c36e531bed3d840077b059f2"><img src="https://joss.theoj.org/papers/b9f135b1c36e531bed3d840077b059f2/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/b9f135b1c36e531bed3d840077b059f2/status.svg)](https://joss.theoj.org/papers/b9f135b1c36e531bed3d840077b059f2)

Author instructions

Thanks for submitting your paper to JOSS @cpondoc. Currently, there isn't a JOSS editor assigned to your paper.

@cpondoc if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning labels Apr 17, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.03 s (1059.5 files/s, 140128.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          14            383            530           1873
Markdown                         9            200              0            501
XML                              1              0              0            317
TeX                              1             14              0            141
YAML                             5              7              4            111
JavaScript                       1              1              0             18
-------------------------------------------------------------------------------
SUM:                            31            605            534           2961
-------------------------------------------------------------------------------

Commit count by author:

   125	cpondoc
    31	joey-obrien
    10	JosephGuman
     1	Chris Pondoc

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1075

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5281/zenodo.8127026 is OK
- 10.2737/INT-GTR-194 is OK
- 10.1002/eap.1898 is OK
- 10.1109/ACCESS.2021.3055651 is OK
- 10.1111/risa.12944 is OK
- 10.2514/1.g004106 is OK

MISSING DOIs

- No DOI given, and none found for title: A mathematical model for predicting fire spread in...
- No DOI given, and none found for title: Uncertainty aware wildfire management
- 10.3389/fict.2018.00006 may be a valid DOI for title: Using spatial reinforcement learning to build fore...
- No DOI given, and none found for title: Distributed wildfire surveillance with autonomous ...
- 10.3389/ffgc.2022.734330 may be a valid DOI for title: Large-Scale Wildfire Mitigation Through Deep Reinf...
- No DOI given, and none found for title: Gym Cellular Automata
- No DOI given, and none found for title: Gym Forest Fire
- No DOI given, and none found for title: Algorithms for decision making
- No DOI given, and none found for title: Stable-Baselines3: Reliable Reinforcement Learning...

INVALID DOIs

- None

@arfon arfon added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Apr 17, 2024
@arfon
Copy link
Member

arfon commented Apr 17, 2024

@cpondoc - thanks for your submission to JOSS. We're currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy.

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

@cpondoc
Copy link

cpondoc commented Apr 18, 2024

Hey @arfon -- sounds good! We'll take care of fixing up the DOIs in the meantime. Let me know if there's anything else that needs to get taken care of?

@cpondoc
Copy link

cpondoc commented Apr 22, 2024

@editorialbot generate preprint

@editorialbot
Copy link
Collaborator Author

📄 Preprint file created: Find it here in the Artifacts list 📄

@joey-obrien
Copy link

@editorialbot generate preprint

@editorialbot
Copy link
Collaborator Author

📄 Preprint file created: Find it here in the Artifacts list 📄

@crvernon
Copy link

@editorialbot invite @mikemahoney218 as editor

👋 @mikemahoney218 this one looks to be right down your alley from a SME point of view. Would you want to take this on as editor?

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@mikemahoney218
Copy link

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @mikemahoney218 is now the editor

@mikemahoney218
Copy link

Happy to take this one on!

@cpondoc , would you be able to suggest 5 reviewers for this package? Reviewers can come from either our reviewer database or your own network, so long as they don't have a conflict of interest. When you suggest them, please do not ping them using @ -- we'll only do that when we're actually inviting them 😄

After that, I should be able to start pinging people for reviews!

@mikemahoney218 mikemahoney218 removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Apr 24, 2024
@cpondoc
Copy link

cpondoc commented Apr 25, 2024

Hey @mikemahoney218 -- sounds great! We will get back to you in the next day or two with a list of 5 reviewers for this package. Just thought I'd acknowledge the message in the interim -- thanks again!

@cpondoc
Copy link

cpondoc commented Apr 25, 2024

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @cpondoc, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Run checks and provide information on the repository and the paper file
@editorialbot check repository

# Check the references of the paper for missing DOIs
@editorialbot check references

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers

@cpondoc
Copy link

cpondoc commented Apr 25, 2024

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5281/zenodo.8127026 is OK
- 10.2737/INT-GTR-194 is OK
- 10.1002/eap.1898 is OK
- 10.48550/arXiv.2010.07915 is OK
- 10.3389/FICT.2018.00006 is OK
- 10.2514/1.G004106 is OK
- 10.3389/ffgc.2022.734330 is OK
- 10.1109/ACCESS.2021.3055651 is OK
- 10.1111/risa.12944 is OK
- 10.2514/1.g004106 is OK

MISSING DOIs

- No DOI given, and none found for title: A mathematical model for predicting fire spread in...
- No DOI given, and none found for title: Gym Cellular Automata
- No DOI given, and none found for title: Gym Forest Fire
- No DOI given, and none found for title: Algorithms for decision making
- No DOI given, and none found for title: Stable-baselines3: reliable reinforcement learning...

INVALID DOIs

- None

@joey-obrien
Copy link

@editorialbot generate preprint

@editorialbot
Copy link
Collaborator Author

📄 Preprint file created: Find it here in the Artifacts list 📄

@mikemahoney218
Copy link

mikemahoney218 commented Apr 25, 2024

Just in case it's helpful, people often want @editorialbot generate pdf rather than generate preprint -- pdf generates the formatted PDF file that you'd get after acceptance (and is persistent over time), while preprint generates TeX (and disappears after a few hours).

@cpondoc
Copy link

cpondoc commented Apr 25, 2024

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5281/zenodo.8127026 is OK
- 10.2737/INT-GTR-194 is OK
- 10.1002/eap.1898 is OK
- 10.48550/arXiv.2010.07915 is OK
- 10.3389/FICT.2018.00006 is OK
- 10.2514/1.G004106 is OK
- 10.3389/ffgc.2022.734330 is OK
- 10.1109/ACCESS.2021.3055651 is OK
- 10.1111/risa.12944 is OK
- 10.2514/1.g004106 is OK

MISSING DOIs

- No DOI given, and none found for title: A mathematical model for predicting fire spread in...
- No DOI given, and none found for title: Gym Cellular Automata
- No DOI given, and none found for title: Gym Forest Fire
- No DOI given, and none found for title: Algorithms for decision making

INVALID DOIs

- 10.5555/3546258.3546526 is INVALID

@cpondoc
Copy link

cpondoc commented Apr 25, 2024

Hey @mikemahoney218 — thanks again for the top about generate pdf! We’re still looking for reviewers, but I also wanted to update you on some of the DOI logistics. In particular:

  • Gym Cellular Automata and Gym Forest Fire are just open-source packages/GitHub repositories with no literature associated with them
  • Algorithms for Decision Making is a textbook with no associated DOI
  • A mathematical model… is a paper from the USDA Forest Service from the 1970’s, so we also don’t believe there’s a DOI there
  • The invalid DOI is for Stable-Baselines 3. Looking at the official link on the ACM website, the DOI we gave is what is in the URL as well as what is used by other papers that cite the authors. However, it seems to be marked as invalid (and it also seems to be undiscoverable from the POV of doi.org, as well)

Thanks again!

@mikemahoney218
Copy link

Thanks! The Stable-baselines3 case is weird; JMLR doesn't assign DOIs (which is a weird decision in the first place) and it seems like ACM generates a "fake" DOI in its url, though if you click the "citation" button on that page or the JMLR original, there's no DOI field in the generated bibtex. I think the best option would be to remove the DOI from that entry, as it's not a valid DOI.

Entries with no DOI are fine -- we want to make sure we're using DOIs wherever applicable, but we understand some resources don't. I haven't checked, but if you can make sure you've got the ISBN included for Algorithms for Decision Making, that'll be all set.

@cpondoc
Copy link

cpondoc commented Apr 26, 2024

Sounds great! We just took out the DOI for Stable-baselines3 and also added the ISBN for Algorithms for Decision Making -- that should be everything on the references end!

@cpondoc
Copy link

cpondoc commented Apr 26, 2024

Also -- here are 5 reviewers our team thinks would be great for this package! I linked their JOSS profiles rather than tagging them.

@mikemahoney218
Copy link

mikemahoney218 commented Apr 26, 2024

Thanks @cpondoc ! I'll start reaching out to reviewers Monday. (Editing for my own tracking purposes -- third round of invites sent 2024-05-07)

@mikemahoney218
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@mikemahoney218
Copy link

@editorialbot assign @SamTov as reviewer

@editorialbot
Copy link
Collaborator Author

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

@mikemahoney218
Copy link

@editorialbot add @SamTov as reviewer

(picky bot...)

@editorialbot
Copy link
Collaborator Author

@SamTov added to the reviewers list!

@mikemahoney218
Copy link

@cpondoc I'm having a harder time than usual getting reviewers for this one (not a comment about your work, probably more a comment about it being the end of the semester!). If you've got any suggestions for reviewers from your network (keeping in mind our conflict of interest policy) it'd be a huge help -- and I'll keep reaching out to additional reviewers.

@cpondoc
Copy link

cpondoc commented May 4, 2024

@mikemahoney218 thanks for the note! Will get back to you by next week with any updates!

@mikemahoney218
Copy link

@editorialbot add @shahchiragh as reviewer

@editorialbot
Copy link
Collaborator Author

@shahchiragh added to the reviewers list!

@mikemahoney218
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6739.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Python TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning
Projects
None yet
Development

No branches or pull requests

6 participants