-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: helios: An R package to process heating and cooling degrees for GCAM #6033
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
|
Wordcount for |
Review checklist for @RBhupiConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@mengqi-z I am trying a quick installation and having following dependency issue. Please, check.
|
Hi @RBhupi , thank you for your feedback. This error is caused from one of |
👋 @RBhupi and @ibarraespinosa I am just checking in to make sure you don't forget this review! (although @ibarraespinosa did say no time before AGU, which is this week!) |
@hugoledoux I have finished the review but the |
No! It just means that if there are claims of novelty for a method/algo you can as a reader reproduce them, but if not then just click it. Same for data, if all data necessary for you to test the package are available then you can click it. |
Review checklist for @ibarraespinosaConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@editorialbot generate pdf |
Hello all, just a quick update that I have addressed the comments from @ibarraespinosa in this issue JGCRI/helios#10. Please let me know if there are any further comments or questions. Thank you. |
@hugoledoux @RBhupi @mengqi-z @editorialbot Accepted |
@editorialbot generate pdf |
Hello @hugoledoux @ibarraespinosa @RBhupi, Thank you all for reviewing 'helios' and providing valuable feedback. I believe I have addressed all the existing issues. Please let me know if there is anything else I need to do to complete the reviewing process. Thanks! |
@editorialbot generate pdf |
@mengqi-z I have proof-read the paper and made a PR with two small fixes: JGCRI/helios#17 Also, at l.34, the acronym "IAM" has never been introduced. Can you please fix those? After this point could you:
I can then move forward with recommending acceptance of the submission. |
Hi @hugoledoux, Thank you. I have completed the steps following your instructions. Here is the latest release information:
Please let me know if you need anything else. Thank you. |
@editorialbot generate pdf |
@editorialbot set 10.5281/zenodo.10658818 as archive |
Done! archive is now 10.5281/zenodo.10658818 |
@editorialbot set v1.0.1 as version |
Done! version is now v1.0.1 |
@editorialbot recommend-accept |
|
|
👋 @openjournals/ese-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5035, then you can now move forward with accepting the submission by compiling again with the command |
@mengqi-z thanks, sorry for small delay in processing this. One of our EiC will now take over and might ask for some more (minor) changes. Thanks @ibarraespinosa and @RBhupi for the reviews! I hope you enjoyed it and are up for new JOSS reviews in the future. |
|
Ok looks good to me! |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congrats on your new publication @mengqi-z! Many thanks to editor @hugoledoux and reviewers @RBhupi and @ibarraespinosa for your time, hard work, and expertise!! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Thank you, everyone! @hugoledoux @RBhupi @ibarraespinosa @kthyng |
Submitting author: @mengqi-z (Mengqi Zhao)
Repository: https://github.com/JGCRI/helios
Branch with paper.md (empty if default branch):
Version: v1.0.1
Editor: @hugoledoux
Reviewers: @RBhupi, @ibarraespinosa
Archive: 10.5281/zenodo.10658818
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@RBhupi & @ibarraespinosa, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @hugoledoux know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @RBhupi
📝 Checklist for @ibarraespinosa
The text was updated successfully, but these errors were encountered: