spdemo: fails on MacOS using clang

[dennisguse]

Executing spdemo results in "Abort trap: 6".

The issue seems to be a result of:
FIND_PAR_S (9, "_Left of right adjusted? ..... ", just, just);
https://github.com/dennisguse/stl2009/blob/master/src/utl/spdemo.c#L538

Something goes wrong in this macro.

Issue #42 is related.

[ludomal]

I have stumbled on the same issue while reviewing #107 and I have not realized that there was a bug report already created for this issue.

spdemo expects 9 parameters to be passed as command line and only 8 are passed in the regression tests, thus the error.

There are two sections in spdemo that parse the command line parameters and one of them (lines 530 to 538) looks outdated.

This needs to be reviewed as I am not sure spdemo operates correctly as is. @simaocampos, do you have any insights?

[simaocampos]

Not on the top of my mind, would need to dig into the code and try to remember. I am afraid I will not be able to do that before the SG12 meeting :-(

[dennisguse]

I would furthermore like to replace the macros GET_PAR_X and FIND_PAR_X using regular functions.
Actually a simple task, but will be very helpful for debugging (and using macros here is not really beneficial anyhow).

[simaocampos]

This macro approach was really needed to support weak compilers. I would suggest to keep it. Simão

[dennisguse]

@simaocampos what do you mean by weak compiler?

Would it be problematic to implement these as functions (even inline would be possible)?
I don't see why this might be problematic for newer compilers.

[simaocampos]

Some that had problems handling command line commands. Simão From: Dennis Guse <[email protected]> Sent: Tuesday, 13 November, 2018 21:39 To: openitu/STL <[email protected]> Cc: Campos, Simao <[email protected]>; Mention <[email protected]> Subject: Re: [openitu/STL] spdemo: fails on MacOS using clang (#46) @simaocampos<https://github.com/simaocampos> what do you mean by weak compiler? Would it be problematic to implement these as functions (even inline would be possible)? I don't see why this might be problematic for newer compilers. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#46 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AQXMAtg53SLpJ3hFkERh6mwO1_O416Zdks5uuy3JgaJpZM4M0Vk4>.

[ludomal]

Now solved with #116