-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IP Addresses as a format #206
base: main
Are you sure you want to change the base?
Conversation
IP Addresses as a format
|
||
ips | ||
|
||
> REQUIRED. The array of IP addresses of the subject as observed by the Transmitter. The value MUST be in the format of an array of strings, each one of which represents the RFC 4001 [RFC4001] string representation of an IP address. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add RFC4001 as a reference. Do this at the top of the document by adding RFC4001:
on line 105.
~~~ json | ||
{ | ||
"format": "ips", | ||
"ips": ["10.29.37.75", "98.27.134.237"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"ips": ["10.29.37.75", "98.27.134.237"] | |
"ips": ["203.0.113.75", "2001:0db8:e700:37a7:4cd4::b868"] |
For IPv4 addresses, it is best practice to use allocated example IP ranges (RFC5737). We should also have an IPv6 address in the example (RFC3849).
The IPv6 example uses common shorthand with the double colon. One question is whether we should allow that or require expansion. No opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change of opinion: we should require expanded ones. @timcappalli to find official term (could be "uncompressed", "fully expanded", or "unabbreviated": https://www.ciscopress.com/articles/article.asp?p=2803866)
2024-10-08 call: loose consensus on this
IP Addresses as a format
Closes #201