-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crc checksum input #51
Comments
I thought the table was providing the clarity. But I agree we can make this change to provide better clarity. I will open a PR on the same by tomorrow. |
I think this should be written more precise. I was looking at this: Lines 336 to 344 in e5370d5
The table says checksum of "data" and the text below the table specifies chunk payload as chunk data. One could easily misinterpret this and not include the seqNo in the crc. I can work out a revised definition and create a PR if you want. |
@sschulz-t Yes it would be great if you can. |
Regarding
openid4vp_ble/main.md
Line 344 in e5370d5
In this case i assume the input is the chunk num and chunk data, however the specification should specify it clearly that no assumptions are needed.
The text was updated successfully, but these errors were encountered: