Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate browser API sequence diagrams into the specification #206

Open
jogu opened this issue Jul 4, 2024 · 1 comment · May be fixed by #354
Open

Incorporate browser API sequence diagrams into the specification #206

jogu opened this issue Jul 4, 2024 · 1 comment · May be fixed by #354
Labels
browser-api editorial help wanted Extra attention is needed
Milestone
1.1

Comments

@jogu
Copy link
Collaborator

jogu commented Jul 4, 2024

As per https://github.com/openid/OpenID4VP/pull/155/files#r1653319017 there are some plantuml diagrams added in the browser API PR that are not incorporated into the specification.

We would like those diagrams to be incorporated into the specification.

To avoid synchronisation issues that should happen automatically when the specification is build (e.g. in the GitHub workflow: https://github.com/openid/OpenID4VP/blob/main/.github/workflows/Build-OID4VP.yml ).

It anyone is able to help us get that working it would be greatly appreciated.
@jogu jogu added the help wanted Extra attention is needed label Jul 4, 2024
@jogu jogu mentioned this issue Jul 4, 2024
Merged
@jogu
Copy link
Collaborator Author

jogu commented Jul 4, 2024

Someone on today's WG call (sorry, I have forgotten who!) suggested this tool might be part of a solution:

https://pypi.org/project/pandoc-imagine/

@jogu jogu mentioned this issue Oct 22, 2024
Merged
jogu added a commit that referenced this issue Nov 30, 2024
@jogu
Removed unused examples / unused tests / unused diagrams
dfb9adb 
These are all essentially unmaintained and likely incorrect, so remove
them to avoid misleading anyone.

Anyone who thinks any of these are important is welcome to add them back,
bring them up to date and incorporate them in the spec / GitHub actions
as appropriate.

closes #206 (by making it irrelevant)
@jogu jogu linked a pull request Nov 30, 2024 that will close this issue
Open
@Sakurann Sakurann added this to the 1.1 milestone Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
browser-api editorial help wanted Extra attention is needed
Projects
None yet
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

Removed unused examples / unused tests / unused diagrams openid/OpenID4VP
2 participants
@jogu @Sakurann