You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are various things that look like inconsistencies in the jwt_vp examples, e.g.:
The VP spec only defines jwt_vp_json, so jwt_vp there should probably be changed to jwt_vp_json.
We have some presentation examples that use "format": "jwt_vp" and some with "format": "jwt_vp_json". I am not sure which should be used but I presume we should be consistent. jwt_vp_json does not exist in the PE registry: https://identity.foundation/claim-format-registry/#registry
The text was updated successfully, but these errors were encountered:
for the vcdm v1.1, for the VCs there is a distinction between jwt_vc_json and jwt_vc_json-ld (which is defined in VCI, but not VP), but for VP I think that distinction matters less, so jwt_vp might be ok.
and yes, someone needs to take an action and register identifiers defined in Openid4vc in that DIF registry..
for the vcdm v1.1, for the VCs there is a distinction between jwt_vc_json and jwt_vc_json-ld (which is defined in VCI, but not VP), but for VP I think that distinction matters less, so jwt_vp might be ok.
To clarify, are you suggesting we change the type that VP defines from jwt_vc_json to jwt_vc here:
I was suggeting to use jwt_vc_json and jwt_vp, but you are right, spec text itself defines jwt_vp_json, so I did a PR #145 to stick to jwt_vp_everywhere
There are various things that look like inconsistencies in the jwt_vp examples, e.g.:
The VP spec only defines
jwt_vp_json
, sojwt_vp
there should probably be changed tojwt_vp_json
.We have some presentation examples that use
"format": "jwt_vp"
and some with "format": "jwt_vp_json". I am not sure which should be used but I presume we should be consistent.jwt_vp_json
does not exist in the PE registry: https://identity.foundation/claim-format-registry/#registryThe text was updated successfully, but these errors were encountered: