You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Depending on the distro being used, we install different versions of tools. For example, we install versions of python between 3.9 and 3.12. Investigate automated way of ensuring our scripts our compatible with all of these versions. This has already caused some issues for @rosethompson with python 3.12, and when working on the updated version of wsim I ran into the opposite issue and attempted to use a feature not present in python 3.9.
Investigating adding some kind of python linting as a CI check. Potentially using Ruff.
The text was updated successfully, but these errors were encountered:
Working on this in conjunction with the ongoing major cleanup/refactoring of many of the python scripts that I've been doing. Once that is complete, I will enable the Ruff linter in CI and have it lint for all versions of python from 3.9 onwards to ensure we don't have compatibility issues.
If we want to we can also enable pre-commit checks so that people can see the ruff lint failures before committing instead of just when the CI fails.
On Dec 31, 2024, at 12:06 AM, Jordan Carlin ***@***.***> wrote:
Working on this in conjunction with the ongoing major cleanup/refactoring of many of the python scripts that I've been doing. Once that is complete, I will enable the Ruff linter in CI and have it lint for all versions of python from 3.9 onwards to ensure we don't have compatibility issues.
If we want to we can also enable pre-commit checks so that people can see the ruff lint failures before committing instead of just when the CI fails.
—
Reply to this email directly, view it on GitHub <#1176 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AR4AA3YOI7QPFNUJZ5SUBED2IJF63AVCNFSM6AAAAABTGSKKLOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRWGIZDEOJYHE>.
You are receiving this because you are subscribed to this thread.
Depending on the distro being used, we install different versions of tools. For example, we install versions of python between 3.9 and 3.12. Investigate automated way of ensuring our scripts our compatible with all of these versions. This has already caused some issues for @rosethompson with python 3.12, and when working on the updated version of wsim I ran into the opposite issue and attempted to use a feature not present in python 3.9.
Investigating adding some kind of python linting as a CI check. Potentially using Ruff.
The text was updated successfully, but these errors were encountered: