Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate a way to test python scripts for compatibility with all supported versions in install script #1176

Open
jordancarlin opened this issue Dec 7, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@jordancarlin
Copy link
Member

jordancarlin commented Dec 7, 2024

Depending on the distro being used, we install different versions of tools. For example, we install versions of python between 3.9 and 3.12. Investigate automated way of ensuring our scripts our compatible with all of these versions. This has already caused some issues for @rosethompson with python 3.12, and when working on the updated version of wsim I ran into the opposite issue and attempted to use a feature not present in python 3.9.

Investigating adding some kind of python linting as a CI check. Potentially using Ruff.

@jordancarlin jordancarlin added the enhancement New feature or request label Dec 19, 2024
@jordancarlin jordancarlin self-assigned this Dec 19, 2024
@jordancarlin
Copy link
Member Author

Working on this in conjunction with the ongoing major cleanup/refactoring of many of the python scripts that I've been doing. Once that is complete, I will enable the Ruff linter in CI and have it lint for all versions of python from 3.9 onwards to ensure we don't have compatibility issues.

If we want to we can also enable pre-commit checks so that people can see the ruff lint failures before committing instead of just when the CI fails.

@davidharrishmc
Copy link
Contributor

davidharrishmc commented Dec 31, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants