Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[X2] AMO dont set rvfi_mem_rmask #912

Open
silabs-krdosvik opened this issue Aug 18, 2023 · 0 comments
Open

[X2] AMO dont set rvfi_mem_rmask #912

silabs-krdosvik opened this issue Aug 18, 2023 · 0 comments
Labels
Component:Other Non-RTL, non-documentation (e.g. bhv, sva) Type:Bug For bugs in any content (RTL, Documentation, etc.)

Comments

@silabs-krdosvik
Copy link
Contributor

AMO dont set rvfi_mem_rmask

AMO operations do both loads and stores:
image

However, we see that the rvfi_mem_rmask is not set for AMOs:
image

The reason seems to be that rmask is only set if the lsu dont do a write:
image

(As mentioned AMOs do both writes and reads, so we should use another strategy set mem_rmask)

Component

Indicate the component in which you found a problem (and we will add the appropriate label):

Component:RTL: (https://github.com/openhwgroup/cv32e40x/blob/master/bhv/cv32e40x_rvfi.sv)
**Component:Doc **:(https://docs.openhwgroup.org/projects/cv32e40x-user-manual/en/latest/atomics.html)

Steps to Reproduce

Please provide:

  1. git hash: c788954
@Silabs-ArjanB Silabs-ArjanB added Component:Other Non-RTL, non-documentation (e.g. bhv, sva) Type:Bug For bugs in any content (RTL, Documentation, etc.) labels Aug 18, 2023
@Silabs-ArjanB Silabs-ArjanB changed the title AMO dont set rvfi_mem_rmask [X2] AMO dont set rvfi_mem_rmask Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:Other Non-RTL, non-documentation (e.g. bhv, sva) Type:Bug For bugs in any content (RTL, Documentation, etc.)
Projects
None yet
Development

No branches or pull requests

2 participants