Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog is not properly generated for pdf version of the specification #157

Open
jquevremont opened this issue Feb 21, 2024 · 7 comments
Labels
documentation Improvements or additions to documentation post-v1.0 To be fixed after v1.0.0 release public-review Issues during public review

Comments

@jquevremont
Copy link

As there have been early implementations of CV-X-IF (CVA6, CV32E40X, Vicuna...), could you add a note about the compatibility of CV-X-IF v1.0.0 specification with core-v-xif_v0.2.0 GitHub release dates 2022-04-22?

@jquevremont jquevremont added documentation Improvements or additions to documentation public-review Issues during public review labels Feb 21, 2024
@christian-herber-nxp
Copy link
Contributor

I tried to list the relevant changes in the changelog of the v1.0.0-rc.1 release. Tag core-v-xif_v0.2.0 is equivalent to v0.2.0 with the only difference that v0.2.0 has a fixed build.

Does this clarify? Any action needed?

@jquevremont
Copy link
Author

Thanks for pointing this. I can read it in https://github.com/openhwgroup/core-v-xif/releases/tag/v1.0.0-rc.1. I was looking for this information in the PDF file.

@christian-herber-nxp
Copy link
Contributor

I see. It is also here in the html: https://docs.openhwgroup.org/projects/openhw-group-core-v-xif/en/latest/preface.html#changelog
No idea why sphinx does not pick that up for the pdf version. Seems to be a limitation in Sphinx. It is the same issue in CV32E40P documentation. We could file in an issue with Sphinx, to have an option to include the text, as that would be really useful.

@christian-herber-nxp
Copy link
Contributor

Created this ticket ewjoachim/sphinx-github-changelog#122

@jquevremont
Copy link
Author

Alternatively, this could be written in section 3.1 History.

@christian-herber-nxp
Copy link
Contributor

Alternatively, this could be written in section 3.1 History.

We can write a manual changelog, that wouldn't be an issue. But the point is to have no duplication of anything, and this integration with github allows this, so I think we should stick to it but make it work.

@jquevremont
Copy link
Author

jquevremont commented Feb 23, 2024

I understand. Until the Sphinx ticket is solved, I suggest to add a manual changelog as a temporary workaround. And a core-v-xif issue could be created in order to remove the workaround when the issue is fixed in Sphinx.

@christian-herber-nxp christian-herber-nxp added question Further information is requested documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation question Further information is requested labels Feb 23, 2024
@christian-herber-nxp christian-herber-nxp changed the title Document compatibility of 1.0.0 specification with core-v-xif_v0.2.0 release Changelog is not properly generated for pdf version of the specification Feb 26, 2024
@christian-herber-nxp christian-herber-nxp added the post-v1.0 To be fixed after v1.0.0 release label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation post-v1.0 To be fixed after v1.0.0 release public-review Issues during public review
Projects
None yet
Development

No branches or pull requests

2 participants