[4.2.0] Addons fail to install due to Apache http OSGI components failing to download #1679
Comments
|
Separately - if the above gets confirmed as an issue with just a single binding (ex.: PS. Apology for double posting. Just consider this note to be (likely) orthogonal to the primary root cause, so wanted it to be standalone to be able to link directly to it in the future. |
|
This issue has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/openhab-4-2-release-discussion/157076/151 |
|
Not sure, but this issue might be a better fit into the distro repo @openhab/distro-maintainers, can someone transfer it? |
|
@mbronk I have just uploaded the two Apache libs to our Artifactory at openhab.jfrog.org, from which the online dependencies are loaded. |
|
@kaikreuzer - didn't have much time today, so only made a very rough check. Looks like the # of errors went down (2->1), but Don't have full log (hope to be able to re-test in a few days), only this snippet which I think may be relevant: Could you please check if both artifacts uploaded in the right place? Looking at https://openhab.jfrog.io/ui/native/libs-release/org/apache/httpcomponents/httpclient-osgi/ I do not see 4.5.13 indeed. |
|
Sorry @mbronk, my mistake. The artifact upload must have failed without me noticing or checking thoroughly. |
|
Hi @kaikreuzer - thanks for the note. Appreciate the updates! I can confirm the flow advances further, but there's unfortunately still an error (this time stracktrace attributes it quite vividly to Checked on both As mentioned before, I'm unsure if this is the same issue or should be filed separately, but I think that outside the immediate cause, there are at some areas where improvements may be considered. For example:
Startup log w/ error - fresh 4.2.1 instance, vanilla state (click to expand) |
The same build error is causing the sandbox builds to fail, see: |
|
@wborn The sandbox builds only started failing a week ago - before, the 4.3.0 builds were just fine. @mbronk reports the problem on 4.2.x, though. Do you have any idea, how that fits together? The AWS SDK in PollyTTS has last been updated 8 months ago and it was correctly published through the OSGify build (https://ci.openhab.org/view/Release%20Jobs/job/openhab-osgiify/32/). It is also still present in artifactory as expected. What might be the issue here? |
|
I see the sandbox build succeeds again and I can also install Polly TTS with OH 4.2.1. It probably got fixed by redeploying the artifacts because the openhab-osgiify CI task ran to deploy com.hubspot.jinjava.jinjava, see openhab/openhab-osgiify#48. |
|
It should work for 4.2.x and main again. It took me 2 hours last night to figure out, what was the problem: |
|
Thanks for fixing it Kai! 👍 Looking at the actual JAR content was what I wanted to do next if it was still failing. 😉 |
I confirm. Both Technically this issue can be closed now as the original symptoms are gone. |
|
That's good news! I've created #1686 for addressing the root cause. |
OH
4.2.0fails a 🧹 clean installation w/ pre-populatedaddons.cfgwith the following error:Causing none of the addons to install properly. Subsequent install attempts fail as well.
Possibly some ordering/dependency issue between addons and core and may be related to
pollytts❔Full startup log - fresh instance, vanilla state (click to expand)
Isolation
4.2.0(vsn4.1.3is confirmed working)addons.kardownloaded)Dockerfilebelow)Possible cause:
Did not perform extensive testing (this may be a false lead❗), but on the surface it looks related to
pollyttsand changes introduced in openhab/openhab-addons#16294. Unsure if pollytts is the component at fault though, or just victim to other changes or dependency mix w/ other addons.To reproduce
Using the
Dockerfilelisted below:docker run --name openhab -p 8080:8080 --rm -it $(docker build -q .)addons.kar)docker run --name openhab -p 8080:8080 --rm -it $(docker build -q . --build-arg DOWNLOAD_ADDONS=1)docker run --name openhab -p 8080:8080 --rm -it $(docker build -q . --build-arg OPENHAB_VERSION=4.1.3)addons.kar)docker run --name openhab -p 8080:8080 --rm -it $(docker build -q . --build-arg OPENHAB_VERSION=4.1.3 --build-arg DOWNLOAD_ADDONS=1)
(👆 click to expand...)Dockerfilereproducing the issue (ref. table above for exact commands used)Note: the
Dockerfileabove can be greatly minimized to isolate, but left as-is b/c this is the exact flavor I've used to test with.BTW. if this confirmed as an issue, I'd suggest adding a similar rudimentary test to the CI (include all addons, scan for them installing correctly).
The text was updated successfully, but these errors were encountered: