-
-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add topic filter for event WebSocket #4550
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
e01f161
to
636ba6f
Compare
Depends on openhab/openhab-core#4550. Signed-off-by: Florian Hotze <[email protected]>
@ghys We are getting close to have the event WS support everything we need in the UI 🚀 |
Would it be possible to provide a negative and positive filter here, too? |
Added just a few seconds ago 👍 |
Signed-off-by: Florian Hotze <[email protected]>
b7f417c
to
aa92411
Compare
Is the topic not a regular expression? Is it something openhab specific? |
Topics can be defined as string with the * wildcard, see SSE events. |
I don‘t think that the additional regex features would be a benefit here, I think the wildcard is enough. |
But why use an custom openhab wildcard implementation which then gets internally converted into regex instead of just allowing a regex from the start instead? |
It makes the filters easier to use from clients though, as you can simply specify the topic with wildcards and don't need to take care of the RegEx. |
Closes #4549.
Closes #3764.
The topic filter can be configured by sending a WS message like in following examples:
Only send all ItemCommandEvents:
Only send all ItemCommandEvents, except for the
test
Item:Send all events, except ItemCommandEvents: