Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AndroidTV] PhilipsTV power channel change values after thing thing got offline #18159

Open
NikolayKash opened this issue Jan 22, 2025 · 6 comments · May be fixed by #18263
Open

[AndroidTV] PhilipsTV power channel change values after thing thing got offline #18159

NikolayKash opened this issue Jan 22, 2025 · 6 comments · May be fixed by #18263
Assignees
@morph166955
Labels
bug An unexpected problem or unintended behavior of an add-on

Comments

@NikolayKash
Copy link

NikolayKash commented Jan 22, 2025 •
edited
Loading

Expected Behavior

Keep value as OFF, instead setting it ON and immediately set it to OFF after thing got online

Current Behavior

Item value is OFF
Thing got OFFINE
Thing get ONLINE
Item value set to ON
Almost the same time it gets OFF.

PSA screenshot

Image

Possible Solution

keep OFF value instead of ON

Steps to Reproduce (for Bugs)

Item value is OFF
Thing got OFFINE
Thing get ONLINE
Item value set to ON
Almost the same time it gets OFF.

Context

I have a PhilipsTV and use this configuration

Image

As I persist state of TV there are lots of ON OFF entries generated during a day while TV was off full day.

Could it be related to this logic?

openhab-addons/bundles/org.openhab.binding.androidtv/src/main/java/org/openhab/binding/androidtv/internal/protocol/philipstv/service/PowerService.java

Line 69 in 4dfaef9

handler.checkPendingPowerOn();

Debug log around the issue:

Image

Your Environment

runtimeInfo:
  version: 4.3.2
  buildString: Release Build
systemInfo:
  javaVersion: 17.0.13
  javaVendor: Ubuntu
  osName: Linux
  osVersion: 6.8.0-51-generic

addons:
  - binding-androidtv
  
clientInfo:
  device:
    desktop: true
    language: en-US
    languages:
      - en-US
    onLine: true
    platform: Linux x86_64
@NikolayKash NikolayKash added the bug An unexpected problem or unintended behavior of an add-on label Jan 22, 2025
@openhab-bot
Copy link
Collaborator

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/androidtv-binding-3-2-0-4-2-0/142203/562

@morph166955
Copy link
Contributor

morph166955 commented Jan 26, 2025 •
edited
Loading

EDIT: I found the offending code.

openhab-addons/bundles/org.openhab.binding.androidtv/src/main/java/org/openhab/binding/androidtv/internal/protocol/philipstv/PhilipsTVConnectionManager.java

Line 537 in 4dfaef9

handler.updateChannelState(CHANNEL_POWER, OnOffType.ON);

When the thing state is set to online (and not in standby) it auto sets the power to ON. We probably should be calling for it to refresh instead.

@NikolayKash
Copy link
Author

Hi @morph166955 it looks so. If you can create a fix and publish a bundle, I can test it.

@morph166955
Copy link
Contributor

Working on that right now. Just moved to a new dev box and I'm having issues with Maven. Once I get that resolved I should be able to build a test jar. Might be a few days, not sure why it's breaking currently.

@morph166955 morph166955 self-assigned this Jan 26, 2025
@NikolayKash
Copy link
Author

Hi @morph166955 could you please update me about the fix?

@morph166955 morph166955 linked a pull request Feb 13, 2025 that will close this issue
Draft
@morph166955
Copy link
Contributor

Please try this JAR
https://github.com/morph166955/openhab-addons/releases/download/androidtv-beta/org.openhab.binding.androidtv-5.0.0-SNAPSHOT.jar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@morph166955 morph166955

Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[androidtv] Resolve PhilipsTV Power State Issues morph166955/openhab-addons
3 participants
@openhab-bot @NikolayKash @morph166955