Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config.xml example file is missing the config tag #261

Open
ihsanyapicioglu opened this issue Oct 23, 2023 · 2 comments
Open

Config.xml example file is missing the config tag #261

ihsanyapicioglu opened this issue Oct 23, 2023 · 2 comments
Assignees
Labels

Comments

@ihsanyapicioglu
Copy link

Dear all,

When the project is being updated to 1.40 or to the master branch, it uses the teamengine-core version 5.6.1. In this dependency, a method named getOrganizations has been implemented to Config.java class. This method is looking for a "config" tag inside of the given config.xml file. However in the config.xml file under "src/main/config/teamengine" directory of ets-wfs20 project's master branch and 1.40 tag, there is no config tag. Most probably this example config file has not been updated yet after updating the dependency of the teamengine.

@dstenger dstenger self-assigned this Oct 24, 2023
@dstenger
Copy link
Contributor

Thank you for reporting.

You are probably referring to this pull request? opengeospatial/teamengine#562
This pull request reduces the preconditions for a config.xml file. So, it does not add any new functionality.

The line you are referencing

            Element configElem = (Element) (doc.getElementsByTagName("config")
                    .item(0));

was just refactored to this new method and already existed before.
After parsing the config.xml the first child is config which is retrieved by that line.

So, the config.xml must not be updated as this pull request does not change the requirements for that file.

@dstenger
Copy link
Contributor

@ihsanyapicioglu Can you please confirm if my answer solves your problem? If not, can you please provide more details?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Waiting
Development

No branches or pull requests

2 participants