Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a as_aoi parameter in the add_layer method #532

Open
26 tasks
12rambau opened this issue Jul 5, 2022 · 0 comments
Open
26 tasks

add a as_aoi parameter in the add_layer method #532

12rambau opened this issue Jul 5, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@12rambau
Copy link
Member

12rambau commented Jul 5, 2022

  • Can we add "as_aoi" (or "with_zoom") parameter to the "add_layer/addLayer" method? if the aoi_control is not on the map, we can create it, and if it is, just add layer_name + bounds?
  • Also, if an aoi_layer (or "with_zoom" layer) is removed from the map, can we remove it from the control (without an extra call).

Perhaps we can have a Dict trait in the map ({name:[bounds]}), overwritten every time a new "as_aoi" layer is added, and an Aoi Control, listening every time to add/remove layers "as_aoi"

Originally posted by @dfguerrerom in #491 (review)

Excellent suggestion that completely deserve it's own issue as it leads to many method tuning (add_layer, remove_layer, aoi_control... etc)

The full list of layers that need to be supported:

@12rambau 12rambau changed the title I like this one, it's working perfectly on my side... I have some comments... add a as_aoi parameter in the add_layer method Jul 5, 2022
@12rambau 12rambau added the enhancement New feature or request label Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant