-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4002 - Tablepaginated filter by user role/admin users role - Integration #4038
Conversation
header: t(Users.getI18nRoleLabelKey(roleName)), | ||
key: roleName, | ||
})) | ||
const selectedRoles = useTablePaginatedFilterValue<Array<string>>(path, 'roles') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this selectedRoles ? Should we include in the options just the role independently to the selection ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous implementation had this feature, so I thought we might to do something similar. I will remove it though 👍
@yaguzmang the video doesn't show when there are no roles selected. can u post a comprehensive video please ? |
3364d5f
into
4002-tablepaginated-filter-by-user-role--admin-users-role
* 4002 - Tablepaginated filter by user role/admin users role - Integration (#4038) * 4002 - Add Filter multi select type * 4002 - Add draft multi select to Users table * 2661 - Display all columns * 4002 - TablePaginated: Filter by User Role + Admin users 'Role' - Multiselect UI (#4049) * 4002 - Hide clear button in Text filter * 4002 - Add counter label for multi select * 4002 - Expose Select onMenuClose & onMenuOpen props * 4002 - Add Filter multiselect styling and tooltip * 4002 - Fix table overlapping select options * 4002 - Add spacing between label and search input * 4002 - Fix props order in Select * 4002 - Rename isTooltipVisible to canDisplayTooltip * 4002 - Rename MultiValue to MultiValueSummary * 4002 - Rename multiLabelKey to multiLabelSummaryKey * 4002 - Remove import as OriginalMultiValueProps * 4002 - Render Text x button conditionally * 4002 - Update useTooltipContent * 4002 - Fix styling
This PR is just the integration of the new filter type. It uses the current
Select
component. The new genericMultiSelect
component will be in the next PR.(Updated)
2024-10-17.09-12-58.mp4