4266 - PDF - page space #4410
4266 - PDF - page space #4410
Conversation
…4266-pdf---page-space
|
|
||
| {analysisAndProcessing && <AnalysisDescriptions analysisAndProcessing={analysisAndProcessing} />} | ||
| </div> | ||
| {print && !onlyTables && <div className="page-break" />} |
There was a problem hiding this comment.
Each description should be rendered in its own page . Is it the case ?
There was a problem hiding this comment.
The main problem as seen in the issue that sometimes when we have empty descriptions or different length descriptions we might get only couple of symbols (e.g. on empty we get a dash) on a single page
#4266
One thing I was thinking of we can try to group the subheader with the content if it's possible (I will investigate)
Current PR is proposed fix for the issue, if page-break for descriptions is preferred, let me know
There was a problem hiding this comment.
That was the best compromise we found in past assessment to let the content fit .
We should not alter this behavior, otherwise we'll create other problems
There was a problem hiding this comment.
Sure, should I look into grouping the title with the content to avoid empty pages containig only - ?
Or we can close this PR also
There was a problem hiding this comment.
Sorry @sorja I think the issue is not about dash or descriptions in single page .
I saw some screenshots in the issue that are not about descriptions . Am I mistaken ?
There was a problem hiding this comment.
Also , if there's an empty page after a description , can it be fixed as well ?
There was a problem hiding this comment.
Sure, should we roll back the change regarding descriptions?
I will remove the page break after the chart
There was a problem hiding this comment.
Sure
Also , if there's an empty page after a description , can it be fixed as well ?
I will investigate the issue more in depth and let you know
I think grouping the subheader with the content will resolve the issue
There was a problem hiding this comment.
What do you mean grouping ?
The layout should not change
See the 2020 report on the fra website
There was a problem hiding this comment.
Maybe you want to work on another issue ?
No description provided.