Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new charging engine (waiting) #235

Open
davidlmobley opened this issue Mar 17, 2017 · 3 comments
Open

Migrate to new charging engine (waiting) #235

davidlmobley opened this issue Mar 17, 2017 · 3 comments
Labels

Comments

@davidlmobley
Copy link
Contributor

The February OpenEye toolkit release introduces OEAssignCharges and OEAssignPartialCharges is basically deprecated (see https://docs.eyesopen.com/toolkits/python/quacpactk/OEProtonFunctions/OEAssignCharges.html#OEProton::OEAssignCharges) so we should migrate at some point.

@jchodera
Copy link
Member

How is this used in the "current best practices" manner?

@davidlmobley
Copy link
Contributor Author

@jchodera - I think it's a drop-in-replacement for the old one, but it's possible @cbayly13 has built some of his conformer stuff into it so that we can remove some of the machinery we had to use with the old one. I have this on the list to bring up in my next call with him but have not yet discussed it with him.

@davidlmobley
Copy link
Contributor Author

davidlmobley commented Mar 24, 2017

See choderalab/openmoltools#252 -- we need to NOT do this for now as there is no partial bond order access in the new charging engine; marking as "wontfix" for now.

@davidlmobley davidlmobley changed the title Migrate to new charging engine Migrate to new charging engine (waiting) Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants