Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Artifact Upload Conflicts with Unique Node-Based Names #12783

Closed
chahmedejaz opened this issue Aug 16, 2024 · 0 comments · Fixed by #12789
Closed

Fix Artifact Upload Conflicts with Unique Node-Based Names #12783

chahmedejaz opened this issue Aug 16, 2024 · 0 comments · Fixed by #12789
Assignees
@chahmedejaz
Labels
bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted.

Comments

@chahmedejaz
Copy link
Collaborator

chahmedejaz commented Aug 16, 2024 •
edited
Loading

What we should change and why

Highlighted here and here and it's been reproduced in this build workflow that if the same file name is being uploaded from the different knapsack node, then it's still failed to upload the artifacts in the latest version of upload-artifact action.
We need to use artifact names based on the node index such that each artifact name is unique and doesn't conflict with the existing name.
@chahmedejaz chahmedejaz added the bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. label Aug 16, 2024
@chahmedejaz chahmedejaz self-assigned this Aug 16, 2024
@github-project-automation github-project-automation bot moved this to All the things 💤 in OFN Delivery board Aug 16, 2024
@chahmedejaz chahmedejaz moved this from All the things 💤 to In Progress ⚙ in OFN Delivery board Aug 16, 2024
@chahmedejaz chahmedejaz mentioned this issue Aug 19, 2024
Merged
4 tasks
@github-project-automation github-project-automation bot moved this from In Progress ⚙ to Done in OFN Delivery board Aug 20, 2024
@chahmedejaz chahmedejaz mentioned this issue Aug 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chahmedejaz chahmedejaz

Labels
bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted.
Projects
OFN Delivery board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Artifact Upload Conflicts with Unique Node-Based Names chahmedejaz/openfoodnetwork
1 participant
@chahmedejaz