Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change taxonomy generation to only change modified lines. #541

Open
alexgarel opened this issue Sep 20, 2024 · 0 comments
Open

Change taxonomy generation to only change modified lines. #541

alexgarel opened this issue Sep 20, 2024 · 0 comments

Comments

@alexgarel
Copy link
Member

Currently we are regenerating the whole taxonomy when we export it.

But this proved to be difficult to use. Taxonomies have to be perfect on Product Opener side to be easy to review and merge.

We need to switch strategy:

  • keep whole taxonomy file content at import time
  • register where each entry start / end (if it's not yet the case, but I think it's already done)
  • keep track of modified entries
  • at export time take original file and only replace the lines the entry was occupying with new lines corresponding to modified entry
@teolemon teolemon removed the epic label Oct 20, 2024
alexgarel added a commit that referenced this issue Oct 31, 2024
* adding a modified property
* adding lines location of entries
* keeping removed entries

The goal is to be able to patch taxonomy text files instead of re-generating them completely

Relates to: #541 and #366
alexgarel added a commit that referenced this issue Oct 31, 2024
* adding a modified property
* adding lines location of entries
* keeping removed entries

The goal is to be able to patch taxonomy text files instead of re-generating them completely

Relates to: #541 and #366
@teolemon teolemon added the export label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants