Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update PropertyFilterSearchTerm validation/parsing #470

Open
eric-nguyen-cs opened this issue Mar 27, 2024 · 0 comments
Open

refactor: update PropertyFilterSearchTerm validation/parsing #470

eric-nguyen-cs opened this issue Mar 27, 2024 · 0 comments

Comments

@eric-nguyen-cs
Copy link
Contributor 

          nit: instead of this pattern I would have added a cached_property "terms" that would have returned a tuple (or dict) with not / inherited / name and value from filter_value and used it everywhere :-)

Originally posted by @alexgarel in #456 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
🧬✎ Taxonomy Editor (General)
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eric-nguyen-cs