Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn the Open Prices privacy warning into a bottom sheet #6183

Closed
teolemon opened this issue Jan 11, 2025 · 5 comments · Fixed by #6213
Closed

Turn the Open Prices privacy warning into a bottom sheet #6183

teolemon opened this issue Jan 11, 2025 · 5 comments · Fixed by #6213
Labels
bottom sheets good first issue Good for newcomers modals Prices

Comments

@teolemon
Copy link
Member

What

Turn the Open Prices privacy warning into a bottom sheet
Screenshot_20250110-131834.png
@monsieurtanuki monsieurtanuki added the good first issue Good for newcomers label Jan 12, 2025
@Afroz-Shaikh
Copy link
Contributor

If this issue hasn't been assigned to anyone yet, I'd like to take it up. Could someone please assign it to me?

@PramodMagadum
Copy link

I would like to work on it, please somebody assign me the issue??

@teolemon
Copy link
Member Author

@Afroz-Shaikh @PramodMagadum have you spotted the relevant code for modals ?

@soni1234s
Copy link

I would like to work on it, can you please assign me this issue?

@Afroz-Shaikh Afroz-Shaikh mentioned this issue Jan 15, 2025
Merged
@Afroz-Shaikh
Copy link
Contributor

Hey @teolemon
I've updated the implementation to convert the Open Prices privacy warning into a ModalBottomSheet. Let me know if this approach aligns with what you had in mind or if any adjustments are required.
#6213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bottom sheets good first issue Good for newcomers modals Prices
Projects
Good first issues across Open Food Facts
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Convert Privacy warning to bottom sheet Afroz-Shaikh/smooth-app
5 participants
@teolemon @monsieurtanuki @Afroz-Shaikh @soni1234s @PramodMagadum