-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: apidoc openApi ecoscore mapping #11009
Open
shinjigi
wants to merge
8
commits into
openfoodfacts:main
Choose a base branch
from
shinjigi:fix_apidoc_ecoscore_mapping
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+120
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix transportation_values - fix values - fix transportation_score - agribalyse_food_code => agribalyse_proxy_food_code
github-actions
bot
added
the
📚 Documentation
Documentation issues improve the project for everyone.
label
Nov 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11009 +/- ##
==========================================
- Coverage 49.54% 49.03% -0.52%
==========================================
Files 67 77 +10
Lines 20650 22243 +1593
Branches 4980 5318 +338
==========================================
+ Hits 10231 10906 +675
- Misses 9131 10003 +872
- Partials 1288 1334 +46 ☔ View full report in Codecov by Sentry. |
teolemon
reviewed
Nov 13, 2024
teolemon
added
the
🌱 Eco-Score
https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products
label
Nov 13, 2024
shinjigi
force-pushed
the
fix_apidoc_ecoscore_mapping
branch
from
November 15, 2024 09:04
90aae74
to
0a05e6a
Compare
github-actions
bot
added
Agribalyse
French LCA database used in Eco-Score computations
📚 OpenAPI
labels
Nov 15, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Agribalyse
French LCA database used in Eco-Score computations
📚 Documentation
Documentation issues improve the project for everyone.
🌱 Eco-Score
https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products
📚 OpenAPI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR introduces several improvements to the API documentation and schema organization:
New Schema File for Country Codes
country-code.yaml
file to centralize country code definitionsCountryCode
enum with all supported country codesCountryValues
schema to standardize country-to-number mappingsProduct Ecoscore Schema Improvements
CountryValues
schematransportation_score
)Packaging Schema Enhancements
number_of_units
quantity_per_unit
and related fieldsrecycling
weight_measured
Agribalyse Schema Updates
agribalyse_proxy_food_code
fieldagribalyse_food_code
fieldco2_agriculture
fieldThe changes improve code organization, reduce duplication, and enhance compatibility with OpenAPI code generators while maintaining backward compatibility with existing data structures.
Related issue(s) and discussion
This refactoring improves schema maintainability and provides better type safety through proper enum definitions and standardized patterns for country-specific data.