Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intuitive editing of preferences vs security parameters #37

Closed
john-gom opened this issue Jun 28, 2024 · 5 comments
Closed

Intuitive editing of preferences vs security parameters #37

john-gom opened this issue Jun 28, 2024 · 5 comments

Comments

@john-gom
Copy link
Collaborator

No description provided.

@hangy
Copy link
Member

hangy commented Jul 28, 2024

Right now, the only user-configurable settings are

  • joining an org for producer accounts,
  • Display barcode in search results
  • Add an edit link in search results

My understanding is that org management has been moved to MongoDB. Therefore, it's not really a task for Keycloak.

The barcode and edit link could be seen as site-specific/client-specific/app-specific setting, which isn't necessarily a task for Keycloak? Right now, we're not getting rid of user.sto entirely (I'd like to not touch HTTP session handling for the first iteration), so we could just keep these settings as-is.

@teolemon teolemon added the ✨ enhancement New feature or request label Jul 30, 2024
@john-gom
Copy link
Collaborator Author

john-gom commented Aug 2, 2024

Hi @hangy . I think my main concern here is one of usability - it is not very nice at the moment to have one page for the above settings and then a different page (inside Keycloak) for things like changing your name and password.

@hangy
Copy link
Member

hangy commented Aug 4, 2024

It's a bit of a philosophical question, IMHO. The way I see it, lots of big sites (think Microsoft or Google) have central settings and maybe something like RBAC in an "account website" such as Keycloak, but if you want to configure your Gmail/Outlook mail settings, you use a separate UI in that application. Likewise, the "display barcode in search results" settings is specific to ProductOpener and irrelevant to the mobile apps, or Robotoff/Hunger Games, for example.

As the settings that are specific to ProductOpener are very few now, they might just be toggles on the search results page, for example

@john-gom
Copy link
Collaborator Author

john-gom commented Aug 12, 2024

Hi @hangy . I'm happy if we want to move the barcode and edit link settings to somewhere where it is easier to toggle them, but I think having a specific settings page that just shows these two settings and then another button to get to the Keycloak page is pretty messy.

I guess the other way to do it would be to have two options when you click on your name:

  • Account Parameters (the current option which would now go straight to Keycloak)
  • Preferences (new option which would just show product specific settings

image

Maybe use a padlock icon for the Account Parameters and the cog for Preferences? What do you think?

@hangy
Copy link
Member

hangy commented Aug 13, 2024

Yes, something like that was what I had in mind. Admins might have to deal with the complicated "parameters" page for bot/moderator/… for a while, but we really can't do everything in one go

@john-gom john-gom changed the title Add settings for all user-configurable settings Intuitive editing of preferences vs security parameters Aug 19, 2024
@teolemon teolemon removed the ✨ enhancement New feature or request label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants