Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addProductToCompare_shouldTrackRightAnalytics_whenProductsAddedToCompare() FAILED #4923

Open
teolemon opened this issue Feb 22, 2023 · 1 comment · Fixed by #4919
Open

addProductToCompare_shouldTrackRightAnalytics_whenProductsAddedToCompare() FAILED #4923

teolemon opened this issue Feb 22, 2023 · 1 comment · Fixed by #4919
Labels
bug Produces incorrect or unexpected result or behaviour. tests

Comments

@teolemon
Copy link
Member

teolemon commented Feb 22, 2023 •
edited
Loading

What

Task :app:testObfPlaystoreDebugUnitTest

ProductCompareViewModelTest > addProductToCompare_shouldEmitAlreadyExistEvent_whenTheSameProductAdded() PASSED

ProductCompareViewModelTest > addProductToCompare_shouldTrackRightAnalytics_whenProductsAddedToCompare() FAILED
    org.mockito.exceptions.verification.TooFewActualInvocations at ProductCompareViewModelTest.kt:109

ProductCompareViewModelTest > onInit_productsAreEmpty() PASSED

ProductCompareViewModelTest > addProductToCompare_shouldAddProducts_whenProductsAreDifferent() FAILED
    com.google.common.truth.ComparisonFailureWithFacts at ProductCompareViewModelTest.kt:72

https://github.com/openfoodfacts/openfoodfacts-androidapp/blob/develop/app/src/test/java/openfoodfacts/github/scrachx/openfood/features/compare/ProductCompareViewModelTest.kt#L109
@teolemon teolemon added the bug Produces incorrect or unexpected result or behaviour. label Feb 22, 2023
@github-actions github-actions bot added the tests label Feb 22, 2023
@teolemon
Copy link
Member Author

@VaiTon could you have a look, so that we can deploy updated versions of OBF, OPF…

@VaiTon VaiTon closed this as completed in 4879d20 Mar 18, 2023
@github-actions github-actions bot mentioned this issue Mar 18, 2023
Merged
VaiTon pushed a commit that referenced this issue Apr 1, 2023
@github-actions
chore(develop): release 3.10.1 (#4919)
359d5d2 
🤖 I have created a release *beep* *boop*
---


##
[3.10.1](v3.10.0...v3.10.1)
(2023-03-31)


### Bug Fixes

* add status_code prop in AnnotationResponse
([17af32c](17af32c)),
closes
[#4896](#4896)
* getImageUrl
([2626919](2626919))
* Product search recycler view data
([#4918](#4918))
([0c0dca1](0c0dca1)),
closes
[#4913](#4913)
* ProductCompareViewModelTest
([4879d20](4879d20)),
closes
[#4923](#4923)
* removed useless RequiresApi annotation as minSdk is 21
([7ccfabf](7ccfabf))
* use setDataAndType instead of data and type in Intent creations
([bfe78a9](bfe78a9))
* wrong mapping causing json deserialization issue
([770d9c2](770d9c2))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@teolemon teolemon reopened this Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Produces incorrect or unexpected result or behaviour. tests
Projects
Native Android app
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(develop): release 3.10.1 openfoodfacts/openfoodfacts-androidapp
1 participant
@teolemon