Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deep link to the Hunger Games logo game #80

Open
Tracked by #250
teolemon opened this issue Dec 26, 2022 · 4 comments
Open
Tracked by #250

Add deep link to the Hunger Games logo game #80

teolemon opened this issue Dec 26, 2022 · 4 comments
Labels
✨ enhancement New feature or request hunger games

Comments

@teolemon
Copy link
Member

teolemon commented Dec 26, 2022

Problem

Add deep links to the Hunger Games logo game, now that it's really performant

What

@sumit-158
Copy link
Member

sumit-158 commented Jan 15, 2023

@teolemon @alexfauquette can't we unify URL params that would make things easier to implement?
eg:

  1. for question hunger game URL params look like "type=category&value_tag=en%3Abeers"
  2. for the hunger Games logo game URL params look like "type=brand&value=ikea"
  3. for product search "tag=toto&tagtype=brands"

@alexfauquette
Copy link
Member

unify URL

I'm not sure to understand the example you provided. Could you please propose a diff about what are and should be URL params? For example if it's currently value and you would like it to work with value_tag. It would help to know how problematic it is

-type=category&value=en:beers
+type=category&value_tag=en:beers

make things easier to implement

To give you some context from hunger games side, some games are more than 4 years old, so I don't know who linked to them, so I need them to stay consistent over time.

Depending on how many modifications are to do, it could be easier to have a getLinksToHungerGame function that translates your internal data to url params than to support multiple params naming for a same value in hunger games.

@sumit-158
Copy link
Member

I'm not sure to understand the example you provided. Could you please propose a diff about what are and should be URL params? For example if it's currently value and you would like it to work with value_tag. It would help to know how problematic it is

-type=category&value=en:beers
+type=category&value_tag=en:beers

I mean to say having the same parameter pattern maybe this one type=category&value_tag=en:beers for logo and product game.

@teolemon
Copy link
Member Author

The blocking PR has been merged. We just agreed with @raphael0202 that this feature would be really nice to have

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request hunger games
Projects
Status: To Discuss & Validate
Status: 📋 Backlog
Development

No branches or pull requests

3 participants