Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tomato, cherry tomato #5

Open
jneubrand opened this issue Jan 19, 2016 · 19 comments
Open

Tomato, cherry tomato #5

jneubrand opened this issue Jan 19, 2016 · 19 comments

Comments

@jneubrand
Copy link

cherrytomatoes
tomato

@jneubrand
Copy link
Author

I probably should change the leaves on the cherry tomatoes, they look too uniform. Also, they look like frolicking Patricks 😜

@jneubrand jneubrand changed the title Tomato, cherry tomato, chili Tomato, cherry tomato Jan 19, 2016
@andru
Copy link
Collaborator

andru commented Jan 19, 2016

c39f0d9c-be2a-11e5-9ccf-04c0a6068c00
c3a09eaa-be2a-11e5-9d54-df1fe9b2834d

Great stuff! I'm throwing in these resized to 24px just so people can see them small.

Maybe bring the highlight on the tomato down to a light pink so it looks a bit less glossy? Also the natural stagger you've given the cherry toms gets lost at smaller sizes. Maybe exaggerate it a bit?

@andru andru mentioned this issue Jan 19, 2016
43 tasks
@simonv3
Copy link
Member

simonv3 commented Jan 19, 2016

These look great. Thanks!

If the tomato white gets set to light pink that makes it 4 colors - are we trying to limit to 3?

@warpling
Copy link
Member

Could be pretty to have a sight ripening gradient down the vine too?

On Jan 19, 2016, 9:31 AM -0800, [email protected], wrote:

These look great. Thanks!

If the tomato white gets set to light pink that makes it 4 colors - are we trying to limit to 3?


Reply to this email directly orview it on GitHub(#5 (comment)).

@warpling
Copy link
Member

@jneubrand
Copy link
Author

Sounds good, I'll do that later!

On Jan 19, 2016, at 09:42, Ryan McLeod [email protected] wrote:

Could be pretty to have a sight ripening gradient down the vine too?

On Jan 19, 2016, 9:31 AM -0800, [email protected], wrote:

These look great. Thanks!

If the tomato white gets set to light pink that makes it 4 colors - are we trying to limit to 3?


Reply to this email directly orview it on GitHub(#5 (comment)).


Reply to this email directly or view it on GitHub.

@andru
Copy link
Collaborator

andru commented Jan 19, 2016

If the tomato white gets set to light pink that makes it 4 colors - are we trying to limit to 3?

Not sure? Is there a benefit to making a rule of that?

@roryaronson
Copy link
Member

I don't think a hard rule is necessary, but I think less is more. Over time we could create an icon style guide to help get some consistency.

@simonv3
Copy link
Member

simonv3 commented Jan 20, 2016

It had come up here: openfarmcc/OpenFarm#685 (comment), I think it makes them easier to scale to smaller sizes. Maybe not a hard rule, but keeping the amount of colours down. I don't know if most plants will need more than 3 or 4 to be recognizable.

@jneubrand
Copy link
Author

tomato
cherrytomatoes

@jneubrand
Copy link
Author

To be honest, I don't like those cherry tomatoes with a gradient. The light pink flare looks a lot better, though.

@jneubrand
Copy link
Author

Here's the 24px versions: tomato 24 cherrytomatoes 24

@andru
Copy link
Collaborator

andru commented Jan 21, 2016

Sweet! I'm agreed about the gradient on the cherry tomatoes. It's a great idea but I don't think it works too well in practice.

@jneubrand
Copy link
Author

Attached is a zip with the two SVGs, tomato with pink flare and cherry tomatoes in one color.
plainsvg-tomato-cherrytomato.zip
I release it under CC0 1.0.

@andru
Copy link
Collaborator

andru commented Jan 21, 2016

Sweet. We're still woking on the processes and whatnot of exactly how we'll export, package, etc icons so I'll leave this open for now.

We'll probably need each icon to be resized to 3 sizes (24,32,64) and submitted with a pull request. I can handle that when the time comes if you like, or if you want to handle it yourself let me know and I'll ping this issue with more info when we've solidified the processes a bit.

@jneubrand
Copy link
Author

@andru: Thanks for the offer! If you want, I can write an imagemagick shell script and submit it via PR...?

@andru
Copy link
Collaborator

andru commented Jan 24, 2016

I reckon most icons will need to be custom designed for each resolution, so a resize script won't do it in those cases.

@andru andru closed this as completed Jan 31, 2016
@andru andru removed the in progress label Jan 31, 2016
@simonv3
Copy link
Member

simonv3 commented Jan 31, 2016

@andru should we make sure we add something to the repo before we close an issue? Otherwise it quietly fade away.

@andru
Copy link
Collaborator

andru commented Jan 31, 2016

Oh, totally, my bad @simonv3, I had it in my head this was merged and done. Reopened.

@andru andru reopened this Jan 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants